sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_from_a_non_dependency_test.dart - Issue 351703004: Improve pub's pubspec error messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_from_a_non_dependency_test.dart

Issue 351703004: Improve pub's pubspec error messages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart ('k') | sdk/lib/_internal/pub/test/upgrade/git/upgrade_to_incompatible_pubspec_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_from_a_non_dependency_test.dart

diff --git a/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_from_a_non_dependency_test.dart b/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_from_a_non_dependency_test.dart

index 64be0157554dca3fe7eb478ee3e354b84f6e6045..1e649c159e38c02a6fd2e212c93da77b0603197b 100644

--- a/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_from_a_non_dependency_test.dart

+++ b/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_from_a_non_dependency_test.dart

@@ -6,6 +6,7 @@ library pub_tests;

import 'package:scheduled_test/scheduled_test.dart';

+import '../../lib/src/exit_codes.dart' as exit_codes;

import '../descriptor.dart' as d;

import '../test_pub.dart';

import '../serve/utils.dart';

@@ -22,11 +23,8 @@ main() {

]).create();

var pub = startPubServe();

- // Ignore the line containing the path to the pubspec.

- pub.stderr.expect(anything);

- pub.stderr.expect('"transformers.foo" refers to a package that\'s not a '

- 'dependency.');

- pub.shouldExit(1);

+ pub.stderr.expect(contains('"foo" is not a dependency.'));

+ pub.shouldExit(exit_codes.DATA);

});

}