Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Unified Diff: sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart

Issue 351703004: Improve pub's pubspec error messages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart
diff --git a/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart b/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart
index 0f6e950754eb7ae73aee17770d100641f28ea646..79f0fcbe82245454d99aaf9ef43045977b49c56f 100644
--- a/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart
+++ b/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart
@@ -4,6 +4,9 @@
library pub_tests;
+import 'package:scheduled_test/scheduled_test.dart';
+
+import '../../lib/src/exit_codes.dart' as exit_codes;
import '../descriptor.dart' as d;
import '../test_pub.dart';
import '../serve/utils.dart';
@@ -26,11 +29,9 @@ main() {
createLockFile('myapp', pkg: ['barback']);
var pub = startPubServe();
- pub.stderr.expect(emitsLines(
- 'Error in pubspec for package "myapp" loaded from pubspec.yaml:\n'
- 'Invalid transformer configuration for "transformers.\$nonexistent": '
- 'Unsupported built-in transformer \$nonexistent.'));
- pub.shouldExit(1);
+ pub.stderr.expect(contains('Invalid transformer config: Unsupported '
+ 'built-in transformer \$nonexistent.'));
+ pub.shouldExit(exit_codes.DATA);
});
});
}

Powered by Google App Engine
This is Rietveld 408576698