Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Unified Diff: content/public/browser/web_contents_view_delegate.h

Issue 351683002: Adds link disambiguation popup support to Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: responding to cpu's feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_view_delegate.h
diff --git a/content/public/browser/web_contents_view_delegate.h b/content/public/browser/web_contents_view_delegate.h
index b0e3f6255b90fd9be86762263706cd7b71a78a56..27cc0945f3c121dd259e1917becb03d1a833f044 100644
--- a/content/public/browser/web_contents_view_delegate.h
+++ b/content/public/browser/web_contents_view_delegate.h
@@ -9,7 +9,9 @@
#import <Cocoa/Cocoa.h>
#endif
+#include "base/callback_forward.h"
#include "content/common/content_export.h"
+#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/native_widget_types.h"
#if defined(OS_MACOSX)
@@ -22,6 +24,7 @@ class Size;
namespace ui {
class FocusStoreGtk;
+class GestureEvent;
}
namespace content {
@@ -34,6 +37,8 @@ struct ContextMenuParams;
// WebContentsView implementation.
class CONTENT_EXPORT WebContentsViewDelegate {
public:
+ typedef base::Callback<void(ui::GestureEvent* event)> GestureCallback;
jam 2014/07/22 01:04:26 nit: convention in content api is to put the callb
luken 2014/07/30 19:17:31 Done.
+
virtual ~WebContentsViewDelegate() {}
// Returns a delegate to process drags not handled by content.
@@ -43,6 +48,11 @@ class CONTENT_EXPORT WebContentsViewDelegate {
virtual void ShowContextMenu(RenderFrameHost* render_frame_host,
const ContextMenuParams& params) = 0;
+ virtual void ShowLinkDisambiguationPopup(const gfx::Rect& target_rect,
jam 2014/07/22 01:04:26 nit: document, especially what target_rect is rela
luken 2014/07/30 19:17:31 Done.
+ const SkBitmap& zoomed_bitmap,
+ const gfx::NativeView content,
+ GestureCallback callback) = 0;
jam 2014/07/22 01:04:26 nit: const ref for callback
luken 2014/07/30 19:17:31 Done.
+
#if defined(USE_AURA)
// These methods allow the embedder to intercept WebContentsViewWin's
// implementation of these WebContentsView methods. See the WebContentsView

Powered by Google App Engine
This is Rietveld 408576698