Adds link disambiguation popup support to Windows.

content/public/browser/web_contents_view_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_VIEW_WIN_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_VIEW_WIN_DELEGATE_H_
 
 #if defined(OS_MACOSX)
 #import <Cocoa/Cocoa.h>
 #endif
 
+#include "base/callback_forward.h"
 #include "content/common/content_export.h"
+#include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/native_widget_types.h"
 
 #if defined(OS_MACOSX)
 @protocol RenderWidgetHostViewMacDelegate;
 #endif
 
 namespace gfx {
 class Size;
 }
 
 namespace ui {
 class FocusStoreGtk;
+class GestureEvent;
 }
 
 namespace content {
 class RenderFrameHost;
 class RenderWidgetHost;
 class WebDragDestDelegate;
 struct ContextMenuParams;
 
 // This interface allows a client to extend the functionality of the
 // WebContentsView implementation.
 class CONTENT_EXPORT WebContentsViewDelegate {
  public:
+  typedef base::Callback<void(ui::GestureEvent* event)> GestureCallback;

[jam, 2014/07/22 01:04:26]

nit: convention in content api is to put the callback right above where it's
referenced, i.e. move this to line 51

[luken, 2014/07/30 19:17:31]

Done.

+
   virtual ~WebContentsViewDelegate() {}
 
   // Returns a delegate to process drags not handled by content.
   virtual WebDragDestDelegate* GetDragDestDelegate() = 0;
 
   // Shows a context menu.
   virtual void ShowContextMenu(RenderFrameHost* render_frame_host,
                                const ContextMenuParams& params) = 0;
 
+  virtual void ShowLinkDisambiguationPopup(const gfx::Rect& target_rect,

[jam, 2014/07/22 01:04:26]

nit: document, especially what target_rect is relative to

[luken, 2014/07/30 19:17:31]

Done.

+                                           const SkBitmap& zoomed_bitmap,
+                                           const gfx::NativeView content,
+                                           GestureCallback callback) = 0;

[jam, 2014/07/22 01:04:26]

nit: const ref for callback

[luken, 2014/07/30 19:17:31]

Done.

+
 #if defined(USE_AURA)
   // These methods allow the embedder to intercept WebContentsViewWin's
   // implementation of these WebContentsView methods. See the WebContentsView
   // interface documentation for more information about these methods.
   virtual void StoreFocus() = 0;
   virtual void RestoreFocus() = 0;
   virtual bool Focus() = 0;
   virtual void TakeFocus(bool reverse) = 0;
   virtual void SizeChanged(const gfx::Size& size) = 0;
 #elif defined(OS_MACOSX)
   // Returns a newly-created delegate for the RenderWidgetHostViewMac, to handle
   // events on the responder chain.
   virtual NSObject<RenderWidgetHostViewMacDelegate>*
       CreateRenderWidgetHostViewDelegate(
           RenderWidgetHost* render_widget_host) = 0;
 #endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_VIEW_WIN_DELEGATE_H_