Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 351643002: Fix #include order in snapshot-external.cc (Closed)

Created:
6 years, 6 months ago by jbramley
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix #include order in snapshot-external.cc This corrects a linter complaint. BUG= R=mstarzinger@chromium.org, vogelheim@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/snapshot-external.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jbramley
6 years, 6 months ago (2014-06-23 16:55:37 UTC) #1
vogelheim
lgtm Thanks!
6 years, 6 months ago (2014-06-23 17:06:03 UTC) #2
jbramley
On 2014/06/23 17:06:03, vogelheim wrote: > lgtm > > Thanks! No problem! However, despite writing ...
6 years, 6 months ago (2014-06-23 17:08:40 UTC) #3
Michael Starzinger
LGTM (rubber-stamped).
6 years, 6 months ago (2014-06-23 17:15:19 UTC) #4
jbramley
6 years, 6 months ago (2014-06-23 17:16:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r21947 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698