Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: chrome/browser/history/history_service.cc

Issue 351553004: Port HistoryService::GetVisibleVisitCountToHost to CancelableTaskTracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_service.cc
diff --git a/chrome/browser/history/history_service.cc b/chrome/browser/history/history_service.cc
index cb32da5997e74fe386465f5b1d2f00d620e6a601..fe19cfc65d9d6fe8b63d4c30657248168a7ff1cb 100644
--- a/chrome/browser/history/history_service.cc
+++ b/chrome/browser/history/history_service.cc
@@ -93,6 +93,12 @@ void RunWithQueryRedirectsResult(
callback.Run(url, result->success, &result->redirects);
}
+void RunWithVisibleVisitCountToHostResult(
+ const HistoryService::GetVisibleVisitCountToHostCallback& callback,
+ const history::VisibleVisitCountToHostResult* result) {
+ callback.Run(result->success, result->count, result->first_visit);
+}
+
// Extract history::URLRows into GURLs for VisitedLinkMaster.
class URLIteratorFromURLRows
: public visitedlink::VisitedLinkMaster::URLIterator {
@@ -840,13 +846,23 @@ base::CancelableTaskTracker::TaskId HistoryService::QueryRedirectsTo(
&RunWithQueryRedirectsResult, callback, to_url, base::Owned(result)));
}
-HistoryService::Handle HistoryService::GetVisibleVisitCountToHost(
+base::CancelableTaskTracker::TaskId HistoryService::GetVisibleVisitCountToHost(
const GURL& url,
- CancelableRequestConsumerBase* consumer,
- const GetVisibleVisitCountToHostCallback& callback) {
+ const GetVisibleVisitCountToHostCallback& callback,
+ base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());
- return Schedule(PRIORITY_UI, &HistoryBackend::GetVisibleVisitCountToHost,
- consumer, new history::GetVisibleVisitCountToHostRequest(callback), url);
+ history::VisibleVisitCountToHostResult* result =
+ new history::VisibleVisitCountToHostResult();
+ return tracker->PostTaskAndReply(
+ thread_->message_loop_proxy().get(),
+ FROM_HERE,
+ base::Bind(&HistoryBackend::GetVisibleVisitCountToHost,
+ history_backend_.get(),
+ url,
+ base::Unretained(result)),
+ base::Bind(&RunWithVisibleVisitCountToHostResult,
+ callback,
+ base::Owned(result)));
}
HistoryService::Handle HistoryService::QueryTopURLsAndRedirects(

Powered by Google App Engine
This is Rietveld 408576698