Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5531)

Unified Diff: chrome/browser/history/history_types.h

Issue 351553004: Port HistoryService::GetVisibleVisitCountToHost to CancelableTaskTracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_types.h
diff --git a/chrome/browser/history/history_types.h b/chrome/browser/history/history_types.h
index e0ba22447699c280d7723d8c0b247cfcf5775214..96d57e19067fc7847a181f1b8c1746c7a315449d 100644
--- a/chrome/browser/history/history_types.h
+++ b/chrome/browser/history/history_types.h
@@ -510,6 +510,19 @@ struct QueryRedirectsResult {
RedirectList redirects;
};
+// VisibleVisitCountToHostResult ----------------------------------------------
+
+// VisibleVisitCountToHostResult encapsulate the result of a call to
blundell 2014/06/24 14:08:58 nit: encapsulates.
sdefresne 2014/06/25 12:20:36 Done.
+// HistoryBackend::GetVisibleVisitCountToHost.
+struct VisibleVisitCountToHostResult {
+ // Indicates whether the call to HistoryBackend::GetVisibleVisitCountToHost
blundell 2014/06/24 14:08:58 nit: should you declare the constructor/destructor
sdefresne 2014/06/25 12:20:36 I declared it for the other structure because they
+ // was successfull or not. If false, then both |count| and |first_visit| are
+ // undefined.
+ bool success;
+ int count;
+ base::Time first_visit;
+};
+
// KeywordSearchTermVisit -----------------------------------------------------
// KeywordSearchTermVisit is returned from GetMostRecentKeywordSearchTerms. It

Powered by Google App Engine
This is Rietveld 408576698