content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 351403002: Handler shown in editable field should be removed on any key press on keypad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 351403002: Handler shown in editable field should be removed on any key press on keypad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentView.java ('k') | content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 937a581ae54c90593802df48928a7ec9c02b2236..d870ec2fdf650a6120b082aae4723655006728b6 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1975,7 +1975,7 @@ public class ContentViewCore

return mSelectionHandleController;

}

- private InsertionHandleController getInsertionHandleController() {

+ protected InsertionHandleController getInsertionHandleController() {

jdduke (slow) 2014/06/27 15:25:01 Hmm, exposing the internals of handle manipulation

if (mInsertionHandleController == null) {

mInsertionHandleController = new InsertionHandleController(

getContainerView(), mPositionObserver) {