Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 351403002: Handler shown in editable field should be removed on any key press on keypad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.app.Activity; 8 import android.app.Activity;
9 import android.app.SearchManager; 9 import android.app.SearchManager;
10 import android.content.ContentResolver; 10 import android.content.ContentResolver;
(...skipping 515 matching lines...) Expand 10 before | Expand all | Expand 10 after
526 @VisibleForTesting 526 @VisibleForTesting
527 public AdapterInputConnection getInputConnectionForTest() { 527 public AdapterInputConnection getInputConnectionForTest() {
528 return mInputConnection; 528 return mInputConnection;
529 } 529 }
530 530
531 private ImeAdapter createImeAdapter(Context context) { 531 private ImeAdapter createImeAdapter(Context context) {
532 return new ImeAdapter(mInputMethodManagerWrapper, 532 return new ImeAdapter(mInputMethodManagerWrapper,
533 new ImeAdapter.ImeAdapterDelegate() { 533 new ImeAdapter.ImeAdapterDelegate() {
534 @Override 534 @Override
535 public void onImeEvent(boolean isFinish) { 535 public void onImeEvent(boolean isFinish) {
536 getContentViewClient().onImeEvent(); 536 getContentViewClient().onImeEvent();
jdduke (slow) 2014/06/27 15:25:01 So, is this function not getting called when we de
aurimas (slooooooooow) 2014/06/27 15:55:38 We can simply start calling mViewEmbedder.onImeEve
537 if (!isFinish) { 537 if (!isFinish) {
538 hideHandles(); 538 hideHandles();
539 } 539 }
540 } 540 }
541 541
542 @Override 542 @Override
543 public void onDismissInput() { 543 public void onDismissInput() {
544 getContentViewClient().onImeStateChangeRequested(false); 544 getContentViewClient().onImeStateChangeRequested(false);
545 } 545 }
546 546
(...skipping 1421 matching lines...) Expand 10 before | Expand all | Expand 10 after
1968 } 1968 }
1969 1969
1970 }; 1970 };
1971 1971
1972 mSelectionHandleController.hideAndDisallowAutomaticShowing(); 1972 mSelectionHandleController.hideAndDisallowAutomaticShowing();
1973 } 1973 }
1974 1974
1975 return mSelectionHandleController; 1975 return mSelectionHandleController;
1976 } 1976 }
1977 1977
1978 private InsertionHandleController getInsertionHandleController() { 1978 protected InsertionHandleController getInsertionHandleController() {
jdduke (slow) 2014/06/27 15:25:01 Hmm, exposing the internals of handle manipulation
1979 if (mInsertionHandleController == null) { 1979 if (mInsertionHandleController == null) {
1980 mInsertionHandleController = new InsertionHandleController( 1980 mInsertionHandleController = new InsertionHandleController(
1981 getContainerView(), mPositionObserver) { 1981 getContainerView(), mPositionObserver) {
1982 private static final int AVERAGE_LINE_HEIGHT = 14; 1982 private static final int AVERAGE_LINE_HEIGHT = 14;
1983 1983
1984 @Override 1984 @Override
1985 public void setCursorPosition(int x, int y) { 1985 public void setCursorPosition(int x, int y) {
1986 if (mNativeContentViewCore != 0) { 1986 if (mNativeContentViewCore != 0) {
1987 nativeMoveCaret(mNativeContentViewCore, 1987 nativeMoveCaret(mNativeContentViewCore,
1988 x, y - mRenderCoordinates.getContentOffsetYPix() ); 1988 x, y - mRenderCoordinates.getContentOffsetYPix() );
(...skipping 1329 matching lines...) Expand 10 before | Expand all | Expand 10 after
3318 3318
3319 private native void nativeExtractSmartClipData(long nativeContentViewCoreImp l, 3319 private native void nativeExtractSmartClipData(long nativeContentViewCoreImp l,
3320 int x, int y, int w, int h); 3320 int x, int y, int w, int h);
3321 private native void nativeSetBackgroundOpaque(long nativeContentViewCoreImpl , boolean opaque); 3321 private native void nativeSetBackgroundOpaque(long nativeContentViewCoreImpl , boolean opaque);
3322 3322
3323 private native void nativeResumeResponseDeferredAtStart( 3323 private native void nativeResumeResponseDeferredAtStart(
3324 long nativeContentViewCoreImpl); 3324 long nativeContentViewCoreImpl);
3325 private native void nativeSetHasPendingNavigationTransitionForTesting( 3325 private native void nativeSetHasPendingNavigationTransitionForTesting(
3326 long nativeContentViewCoreImpl); 3326 long nativeContentViewCoreImpl);
3327 } 3327 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698