Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 351223002: Increase timer slack for several browser threads. (Closed)

Created:
6 years, 6 months ago by jeremy
Modified:
6 years, 5 months ago
CC:
aiolos (Not reviewing), chromium-reviews, darin-cc_chromium.org, jam, sullivan, tonyg
Project:
chromium
Visibility:
Public.

Description

Increase timer slack for several browser threads. Set timer slack to maximal value for the following browser threads: * WatchdogThread * DB Thread * File thread * Process Launcher thread * Cache thread BUG=356804 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 5 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jeremy
This CL increases slack for a bunch of browser threads we've identified as being potentially ...
6 years, 6 months ago (2014-06-26 12:55:58 UTC) #1
Mark Mentovai
LGTM
6 years, 6 months ago (2014-06-26 13:05:11 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-06-26 14:50:52 UTC) #3
jeremy
The CQ bit was checked by jeremy@chromium.org
6 years, 6 months ago (2014-06-26 16:28:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/351223002/1
6 years, 6 months ago (2014-06-26 16:29:15 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-26 20:07:51 UTC) #6
commit-bot: I haz the power
Change committed as 280138
6 years, 6 months ago (2014-06-26 22:36:35 UTC) #7
pasko
6 years, 5 months ago (2014-06-27 15:50:28 UTC) #8
Message was sent while issue was closed.
Can you reference results of your testing in the description of this change?

Frankly, my first reaction is: "Don't do this for the cache thread!". The cache
thread is on the critical path to resource fetching, adding extra slack will
likely affect page loading latency for users.

This should not affect Android because the use of the cache thread in
simplecache is limited.

Powered by Google App Engine
This is Rietveld 408576698