Ensure that the controls attribute is correctly reflected in JS.

Ensure that the controls attribute is correctly reflected in JS.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177287

[Fredrik Öhrn, 2014-06-27 13:53:12]

This patch breaks out the controls attribute fix from 182613006 to get the ball
rolling again.

acolwell originally spotted the problem here:
https://codereview.chromium.org/182613006/#msg6

[philipj_slow, 2014-06-27 14:26:19]

https://codereview.chromium.org/351213007/diff/1/Source/core/html/HTMLMediaEl...
File Source/core/html/HTMLMediaElement.h (left):

https://codereview.chromium.org/351213007/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.h:160: // controls
Leave this as it was, since some effort appears to have been made to keep it in
sync with IDL/spec.

[philipj_slow, 2014-06-27 14:45:40]

LGTM, this is clearer and fixes a minor bug. acolwell, WDYT?

(Note that I helped with the test, so I'm more likely to have overlooked
something when reviewing it.)

[philipj_slow, 2014-06-27 14:46:50]

FWIW, we've also verified (locally) that the test fails without this patch.

[acolwell GONE FROM CHROMIUM, 2014-06-30 17:50:16]

lgtm

[philipj_slow, 2014-06-30 20:32:57]

Adam, can you review Source/web/? Thanks!

[adamk, 2014-06-30 20:35:12]

lgtm for Source/web

[philipj_slow, 2014-06-30 21:45:20]

lgtm

[commit-bot: I haz the power, 2014-06-30 21:45:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ohrn@opera.com/351213007/20001

[commit-bot: I haz the power, 2014-06-30 21:48:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/8969)

[commit-bot: I haz the power, 2014-06-30 21:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-30 21:50:54]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/8970)

[Fredrik Öhrn, 2014-07-01 08:13:37]

The CQ bit was checked by ohrn@opera.com

[commit-bot: I haz the power, 2014-07-01 08:14:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ohrn@opera.com/351213007/40001

[commit-bot: I haz the power, 2014-07-01 09:20:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-07-01 10:22:04]

Change committed as 177287