Source/core/html/HTMLMediaElement.h - Issue 351213007: Ensure that the controls attribute is correctly reflected in JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 351213007: Ensure that the controls attribute is correctly reflected in JS. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: REbase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.h

diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h

index 5b2756e307c7194f13580ffbab0eaf47f58488ee..b797b4c26fbef2ac93ea248ba2f361756884ab8f 100644

--- a/Source/core/html/HTMLMediaElement.h

+++ b/Source/core/html/HTMLMediaElement.h

@@ -158,8 +158,7 @@ public:

void durationChanged(double duration, bool requestSeek);

// controls

- bool controls() const;

- void setControls(bool);

+ bool shouldShowControls() const;

double volume() const;

void setVolume(double, ExceptionState&);

bool muted() const;

« no previous file with comments | « LayoutTests/media/video-controls-attribute-fullscreen-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »