Issue 351031: Merge 30631 - Fix up extension badge text drawing....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 351031: Merge 30631 - Fix up extension badge text drawing.... (Closed)

Created:
11 years, 1 month ago by oritm

Modified:
9 years, 4 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com, John Grabowski, Aaron Boodman, pam+watch_chromium.org, Erik does not do reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/branches/229/src/

Visibility:
Public.

Merge 30631 - Fix up extension badge text drawing. Fall abck to the system default font if the preferred font isn't available. Also, only create the SkPaint struct once, not on every paint. Also, make some more things const. BUG=25693 TEST=badge still looks good, that crash goes away Review URL: http://codereview.chromium.org/341045 TBR=estade@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30900

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -54 lines)			Patch
M	app/gfx/font.h	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	app/gfx/font_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/gfx/font_skia.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/gfx/font_win.cc	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	app/resource_bundle.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/resource_bundle.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/tabs/tab_renderer_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/first_run_bubble.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/options/languages_page_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/options/options_group_view.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_action.cc	View	3 chunks	+71 lines, -39 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm