Fix up extension badge text drawing....

Fix up extension badge text drawing.

Fall abck to the system default font if the preferred font isn't available.

Also, only create the SkPaint struct once, not on every paint.

Also, make some more things const.

BUG=25693
TEST=badge still looks good, that crash goes away

(this was committed in r30631)

[Evan Stade, 2009-10-30 00:47:01]

http://www/~estade/no_crawl/badge_text.png

I think it looks slightly worse but I couldn't make it any better (bolding it
made it look awful).

I haven't tested this yet on windows, my client is syncing, so that will be done
in about an hour and a half.

[Aaron Boodman, 2009-10-30 01:23:27]

http://codereview.chromium.org/341045/diff/1/11
File chrome/common/extensions/extension_action.cc (right):

http://codereview.chromium.org/341045/diff/1/11#newcode55
Line 55: ResourceBundle& rb = ResourceBundle::GetSharedInstance();
I think it is pretty common to have Arial on linux machines. Since it looks
better, can we try it first, and if it doesn't exist, fall back to the system
default?

At the very least we should leave it as it was on Windows and OS X.

[Evan Stade, 2009-10-30 01:32:32]

http://codereview.chromium.org/341045/diff/1/11
File chrome/common/extensions/extension_action.cc (right):

http://codereview.chromium.org/341045/diff/1/11#newcode55
Line 55: ResourceBundle& rb = ResourceBundle::GetSharedInstance();
On 2009/10/30 01:23:27, Aaron Boodman wrote:
> I think it is pretty common to have Arial on linux machines. Since it looks
> better, can we try it first, and if it doesn't exist, fall back to the system
> default?

I thought about that, but I thought it would be kind of an odd behavior ("hey,
your chrome is respecting your system settings but mine isn't!"). If a user
thinks arial looks better, they can change their system font...

Besides, for at least some constatns, it would introduce another setting:

mac
windows
linux with arial
linux with no arial (best effort)
 
> At the very least we should leave it as it was on Windows and OS X.

a) Has its appearance been optimized on Mac yet?
b) I haven't tested this yet on windows; I was planning to see how it looked
(maybe this still chooses the same font?) and if worst comes to worst we can
just hardcode it to Arial.

[Evan Martin, 2009-10-30 01:34:51]

Without taking a side (or noting which side this supports), I'll note that the
system font in Vista changed from XP.

[Evan Stade, 2009-10-30 01:40:36]

On Thu, Oct 29, 2009 at 6:34 PM,  <evan@chromium.org> wrote:
> Without taking a side (or noting which side this supports), I'll note that
> the
> system font in Vista changed from XP.
>
> http://codereview.chromium.org/341045
>

I guess we should hardcode it on windows then.

[Aaron Boodman, 2009-10-30 02:07:31]

On Thu, Oct 29, 2009 at 6:32 PM,  <estade@chromium.org> wrote:
> http://codereview.chromium.org/341045/diff/1/11
> File chrome/common/extensions/extension_action.cc (right):
>
> http://codereview.chromium.org/341045/diff/1/11#newcode55
> Line 55: ResourceBundle& rb = ResourceBundle::GetSharedInstance();
> On 2009/10/30 01:23:27, Aaron Boodman wrote:
>>
>> I think it is pretty common to have Arial on linux machines. Since it
>
> looks
>>
>> better, can we try it first, and if it doesn't exist, fall back to the
>
> system
>>
>> default?
>
> I thought about that, but I thought it would be kind of an odd behavior
> ("hey, your chrome is respecting your system settings but mine isn't!").
> If a user thinks arial looks better, they can change their system
> font...

I think that this is a special case because it is an incredibly small
space and we must optimize for the best possible look. If the system
font is set to lucidia cursive or comic sans, we aren't going to use
that. Also, given the very custom visual treatment, I do not think
users would necessarily expect their system font to be respected.

>> At the very least we should leave it as it was on Windows and OS X.
>
> a) Has its appearance been optimized on Mac yet?

No but it has been on Windows, and on Windows it should be Arial. I
also think that it should also be Arial on Linux, unless Arial is not
present, which I suspect is quite odd.

On Mac, the designers suggested Helvetica as a start, but wanted to do
additional investigation.

> b) I haven't tested this yet on windows; I was planning to see how it
> looked (maybe this still chooses the same font?) and if worst comes to
> worst we can just hardcode it to Arial.

The system font is sometimes Tahoma on Windows, I can't remember on
which platforms. I would prefer it was always Arial for the reasons
stated above..

- a

[Evan Stade, 2009-10-30 17:41:23]

On Thu, Oct 29, 2009 at 7:07 PM, Aaron Boodman <aa@chromium.org> wrote:
> On Thu, Oct 29, 2009 at 6:32 PM, =A0<estade@chromium.org> wrote:
>> http://codereview.chromium.org/341045/diff/1/11
>> File chrome/common/extensions/extension_action.cc (right):
>>
>> http://codereview.chromium.org/341045/diff/1/11#newcode55
>> Line 55: ResourceBundle& rb =3D ResourceBundle::GetSharedInstance();
>> On 2009/10/30 01:23:27, Aaron Boodman wrote:
>>>
>>> I think it is pretty common to have Arial on linux machines. Since it
>>
>> looks
>>>
>>> better, can we try it first, and if it doesn't exist, fall back to the
>>
>> system
>>>
>>> default?
>>
>> I thought about that, but I thought it would be kind of an odd behavior
>> ("hey, your chrome is respecting your system settings but mine isn't!").
>> If a user thinks arial looks better, they can change their system
>> font...
>
> I think that this is a special case because it is an incredibly small
> space and we must optimize for the best possible look. If the system
> font is set to lucidia cursive or comic sans, we aren't going to use
> that. Also, given the very custom visual treatment, I do not think
> users would necessarily expect their system font to be respected.
>
>>> At the very least we should leave it as it was on Windows and OS X.
>>
>> a) Has its appearance been optimized on Mac yet?
>
> No but it has been on Windows, and on Windows it should be Arial. I
> also think that it should also be Arial on Linux, unless Arial is not
> present, which I suspect is quite odd.

thestig reports that many stock linux distros (including ubuntu) don't
come with arial because it isn't free.

>
> On Mac, the designers suggested Helvetica as a start, but wanted to do
> additional investigation.
>
>> b) I haven't tested this yet on windows; I was planning to see how it
>> looked (maybe this still chooses the same font?) and if worst comes to
>> worst we can just hardcode it to Arial.
>
> The system font is sometimes Tahoma on Windows, I can't remember on
> which platforms. I would prefer it was always Arial for the reasons
> stated above..

k

[Evan Stade, 2009-10-30 17:53:01]

updated. Tries Arial then falls back to system default. If we want to tweak the
fallback method we can figure out the details of that later (for now this fixes
a crasher).

[Aaron Boodman, 2009-10-30 18:04:29]

LGTM

thanks for your patience with my pixel nitpickery.