Issue 351003002: Remove the ChromeClient.h include from RenderLayerCompositor.h

Issue 351003002: Remove the ChromeClient.h include from RenderLayerCompositor.h (Closed)

Created:
6 years, 6 months ago by philipj_slow

Modified:
6 years, 6 months ago

Reviewers:
Mike West

CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rune+blink, vsevik+blink_chromium.org, caseq+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., kenneth.christiansen, loislo+blink_chromium.org, zoltan1, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-rendering, leviw+renderwatch, blink-layers+watch_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove the ChromeClient.h include from RenderLayerCompositor.h ChromeClient isn't used in RenderLayerCompositor.h at all, so put the includes where they belong and reduce header dependencies somewhat. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176922

Patch Set 1 #

Patch Set 2 : fewer includes #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
M	Source/core/inspector/InspectorLayerTreeAgent.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/page/scrolling/ScrollingCoordinator.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderBoxModelObject.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderLayerScrollableArea.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderView.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/compositing/CompositedLayerMapping.cpp	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/rendering/compositing/CompositingReasonFinder.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/compositing/RenderLayerCompositor.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/core/rendering/compositing/RenderLayerCompositor.cpp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/351003002/20001

6 years, 6 months ago (2014-06-25 12:04:47 UTC) #4

Message was sent while issue was closed.

Change committed as 176922

Expand Messages | Collapse Messages