extensions/common/feature_switch.cc - Issue 350943003: Support global keyboard commands on Chrome OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/feature_switch.cc

Issue 350943003: Support global keyboard commands on Chrome OS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Formatting. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/feature_switch.cc

diff --git a/extensions/common/feature_switch.cc b/extensions/common/feature_switch.cc

index 121dceb25ce89b7efb04f8e5cdde4e4dd52a1ada..1a1e53460e0b3753d30a127a2e6c0d0a10df73d3 100644

--- a/extensions/common/feature_switch.cc

+++ b/extensions/common/feature_switch.cc

@@ -25,11 +25,7 @@ class CommonSwitches {

FeatureSwitch::DEFAULT_DISABLED),

global_commands(

switches::kGlobalCommands,

-#if defined(OS_CHROMEOS)

- FeatureSwitch::DEFAULT_DISABLED),

-#else

FeatureSwitch::DEFAULT_ENABLED),

-#endif

Finnur 2014/06/26 10:37:35 Actually, there's no point in keeping this around

David Tseng 2014/06/27 00:49:11 I wasn't sure if it was needed to (sometimes) disa

prompt_for_external_extensions(

NULL,

#if defined(OS_WIN)