Support global keyboard commands on Chrome OS.

extensions/common/feature_switch.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/feature_switch.h"
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string_util.h"
 #include "extensions/common/switches.h"
 
 namespace extensions {
 
 namespace {
 
 class CommonSwitches {
  public:
   CommonSwitches()
       : easy_off_store_install(
             NULL,
             FeatureSwitch::DEFAULT_DISABLED),
         force_dev_mode_highlighting(
             switches::kForceDevModeHighlighting,
             FeatureSwitch::DEFAULT_DISABLED),
         global_commands(
             switches::kGlobalCommands,
-#if defined(OS_CHROMEOS)
-            FeatureSwitch::DEFAULT_DISABLED),
-#else
             FeatureSwitch::DEFAULT_ENABLED),
-#endif

[Finnur, 2014/06/26 10:37:35]

Actually, there's no point in keeping this around anymore. Please delete this
switch and the corresponding command line flag (switches::kGlobalCommands).

[David Tseng, 2014/06/27 00:49:11]

I wasn't sure if it was needed to (sometimes) disable global commands from the
command line. Done.

         prompt_for_external_extensions(
             NULL,
 #if defined(OS_WIN)
             FeatureSwitch::DEFAULT_ENABLED),
 #else
             FeatureSwitch::DEFAULT_DISABLED),
 #endif
         error_console(
             switches::kErrorConsole,
             FeatureSwitch::DEFAULT_DISABLED),
@@ skipping 117 matching lines @@
 
 void FeatureSwitch::SetOverrideValue(OverrideValue override_value) {
   override_value_ = override_value;
 }
 
 FeatureSwitch::OverrideValue FeatureSwitch::GetOverrideValue() const {
   return override_value_;
 }
 
 }  // namespace extensions