Issue 350693005: Partial revert of r21901

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 350693005: Partial revert of r21901 (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 6 months ago

Reviewers:
Benedikt Meurer, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Partial revert of r21901 Only disable runtime check for sse2 if __SSE2__ is not defined. This is required for the x87 port BUG=none LOG=n R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21927

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -1 line)			Patch
	M	src/base/atomicops_internals_x86_gcc.h	View		3 chunks	+29 lines, -1 line	0 comments	Download
	M	src/base/atomicops_internals_x86_gcc.cc	View		2 chunks	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

Committed patchset #1 manually as r21927 (presubmit successful).

6 years, 6 months ago (2014-06-23 10:18:50 UTC) #3

Jakob Kummerow

6 years, 6 months ago (2014-06-23 12:21:18 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/350693005/diff/1/src/base/atomicops_internals...
File src/base/atomicops_internals_x86_gcc.cc (right):

https://codereview.chromium.org/350693005/diff/1/src/base/atomicops_internals...
src/base/atomicops_internals_x86_gcc.cc:45: false,          // no SSE2
Missing #ifdef. I was wondering how this would compile... turns out it doesn't
:-)

Expand Messages | Collapse Messages