Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/class_view.dart

Issue 350573002: Make retained size human-readable. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/class_view.dart
===================================================================
--- runtime/bin/vmservice/client/lib/src/elements/class_view.dart (revision 37564)
+++ runtime/bin/vmservice/client/lib/src/elements/class_view.dart (working copy)
@@ -12,6 +12,7 @@
@CustomTag('class-view')
class ClassViewElement extends ObservatoryElement {
@published Class cls;
+ @published int retainedBytes;
Cutch 2014/06/23 16:16:39 Does this need to be published? I think observable
koda 2014/06/23 18:44:09 True. Thanks for clarifying!
ClassViewElement.created() : super.created();
Future<ServiceObject> eval(String text) {
@@ -20,8 +21,11 @@
}
// TODO(koda): Add no-arg "calculate-link" instead of reusing "eval-link".
- Future<ServiceObject> retainedSize(String dummy) {
- return cls.isolate.get(cls.id + "/retained");
+ Future<ServiceObject> retainedSize(var dummy) {
+ return cls.isolate.get(cls.id + "/retained")
Cutch 2014/06/23 16:16:39 Maybe add a .get to Class: cls.get('retained');
koda 2014/06/23 18:44:09 Done.
+ .then((ServiceMap obj) {
+ retainedBytes = int.parse(obj['valueAsString']);
+ });
}
void refresh(var done) {

Powered by Google App Engine
This is Rietveld 408576698