Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 350403004: DevTools: Fix breakpoints in source mapped files after reload. (Closed)

Created:
6 years, 6 months ago by vsevik
Modified:
6 years, 5 months ago
Reviewers:
sergeyv
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix breakpoints in source mapped files after reload. Note: Test expectations change for the testBreakpointInCollectedReload test are not caused by the change, but by the change in test harness. These changes reveal an error in BreakpointManager implementation that will be fixed in the following patch. BUG=388131 R=sergeyv Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M LayoutTests/inspector/sources/debugger/breakpoint-manager.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/breakpoint-manager-expected.txt View 3 chunks +5 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/BreakpointManager.js View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vsevik
PTAL
6 years, 6 months ago (2014-06-25 14:58:03 UTC) #1
sergeyv
lgtm.
6 years, 6 months ago (2014-06-25 15:10:41 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 6 months ago (2014-06-26 07:45:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/350403004/1
6 years, 6 months ago (2014-06-26 07:45:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-26 23:05:52 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 00:55:56 UTC) #6
Message was sent while issue was closed. 
Change committed as 177033

Powered by Google App Engine
This is Rietveld 408576698