Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: Source/devtools/front_end/sdk/BreakpointManager.js

Issue 350403004: DevTools: Fix breakpoints in source mapped files after reload. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector/sources/debugger/breakpoint-manager-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/BreakpointManager.js
diff --git a/Source/devtools/front_end/sdk/BreakpointManager.js b/Source/devtools/front_end/sdk/BreakpointManager.js
index e2fc7ed2ecf9e19492051a563e5a93c844530d4d..69f3d155ad9e3ee2efbe1abc59163414c6701fda 100644
--- a/Source/devtools/front_end/sdk/BreakpointManager.js
+++ b/Source/devtools/front_end/sdk/BreakpointManager.js
@@ -698,8 +698,17 @@ WebInspector.BreakpointManager.TargetBreakpoint.prototype = {
this._resetLocations();
if (!this._debuggerId)
return;
- this.target().debuggerModel.removeBreakpoint(this._debuggerId, callbackImmediately ? undefined : this._didRemoveFromDebugger.bind(this));
-
+ var debuggerId = this._debuggerId;
+ this.target().debuggerModel.removeBreakpoint(this._debuggerId, callbackImmediately ? undefined : didRemoveFromDebugger.bind(this));
+
+ /**
+ * @this {WebInspector.BreakpointManager.TargetBreakpoint}
+ */
+ function didRemoveFromDebugger()
+ {
+ if (this._debuggerId === debuggerId)
+ this._didRemoveFromDebugger();
+ }
if (callbackImmediately)
this._didRemoveFromDebugger();
},
« no previous file with comments | « LayoutTests/inspector/sources/debugger/breakpoint-manager-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698