Cleanup CallInterfaceDescriptor

Cleanup CallInterfaceDescriptor

Make CallInterfaceDescriptor work like CodeStubInterfaceDescriptor, owning it's
register and representation arrays. This also eliminates a host of TSAN warnings
for static arrays.

This CL depends on https://codereview.chromium.org/352583002 landing first
(a conceptual dependency at least).

R=svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22014

[mvstanton, 2014-06-25 07:46:37]

Hi Sven,
This does for CallInterfaceDescriptor the previous CL does for
CodeStubInterfaceDescriptor. Thx for the look!
--Michael

[Sven Panne, 2014-06-25 08:15:21]

LGTM with a proposal for an enhancement, but we can leave that for another
cleanup CL (perhaps add a TODO then).

https://codereview.chromium.org/350293003/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/350293003/diff/1/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:325: descriptor->Initialize(ARRAY_SIZE(registers),
registers,
It would be nice if there was a type for the Register/Representation pair, this
would be less redundant, more readable and gives stronger static guarantees:

   RegRep params[] = { RegRep(r1, Representation::Tagged()),
                       RegRep(cp, Representation::Tagged()),
                       RegRep(r0, Representation::Integer32()),
                       RegRep(r2, Representation::Integer32()),
                       NULL
   };
   descriptor->Initialize(params);

This is close to what one would write in our hopefully bright C++11 future:

   std::vector<RegRep> params { {r1, Representation::Tagged()},
                                {cp, Representation::Tagged()},
                                {r0, Representation::Integer32()},
                                {r2, Representation::Integer32()}
   };
   descriptor->Initialize(params);

Perhaps one would need a better name than RegRep. :-)

[mvstanton, 2014-06-25 12:45:23]

Thanks Sven!
--Michael

https://codereview.chromium.org/350293003/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/350293003/diff/1/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:325: descriptor->Initialize(ARRAY_SIZE(registers),
registers,
On 2014/06/25 08:15:21, Sven Panne wrote:
> It would be nice if there was a type for the Register/Representation pair,
this
> would be less redundant, more readable and gives stronger static guarantees:
> 
>    RegRep params[] = { RegRep(r1, Representation::Tagged()),
>                        RegRep(cp, Representation::Tagged()),
>                        RegRep(r0, Representation::Integer32()),
>                        RegRep(r2, Representation::Integer32()),
>                        NULL
>    };
>    descriptor->Initialize(params);
> 
> This is close to what one would write in our hopefully bright C++11 future:
> 
>    std::vector<RegRep> params { {r1, Representation::Tagged()},
>                                 {cp, Representation::Tagged()},
>                                 {r0, Representation::Integer32()},
>                                 {r2, Representation::Integer32()}
>    };
>    descriptor->Initialize(params);
> 
> Perhaps one would need a better name than RegRep. :-)

Good idea. Let me add the TODO up in code-stubs.h, on the initialize method,
which accepts the two parallel arrays. The RegRep structure will end up defined
there later.

[mvstanton, 2014-06-25 12:53:10]

Committed patchset #3 manually as r22014 (presubmit successful).