Cleanup CallInterfaceDescriptor

src/code-stubs.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_CODE_STUBS_H_
 #define V8_CODE_STUBS_H_
 
 #include "src/allocation.h"
 #include "src/assembler.h"
 #include "src/codegen.h"
@@ skipping 349 matching lines @@
 
   Address deoptimization_handler_;
   HandlerArgumentsMode handler_arguments_mode_;
 
   ExternalReference miss_handler_;
   bool has_miss_handler_;
   DISALLOW_COPY_AND_ASSIGN(CodeStubInterfaceDescriptor);
 };
 
 
-struct PlatformCallInterfaceDescriptor;
+class PlatformCallInterfaceDescriptor;
 
 
-struct CallInterfaceDescriptor {
+class CallInterfaceDescriptor {
+ public:
   CallInterfaceDescriptor()
       : register_param_count_(-1),
         register_params_(NULL),
         param_representations_(NULL),
         platform_specific_descriptor_(NULL) { }
 
+  // A copy of the passed in registers and param_representations is made
+  // and owned by the CallInterfaceDescriptor.
+
+  // TODO(mvstanton): Instead of taking parallel arrays register and
+  // param_representations, how about a struct that puts the representation
+  // and register side by side (eg, RegRep(r1, Representation::Tagged()).
+  // The same should go for the CodeStubInterfaceDescriptor class.
+  void Initialize(int register_parameter_count, Register* registers,
+                  Representation* param_representations,
+                  PlatformCallInterfaceDescriptor* platform_descriptor = NULL);
+
   bool initialized() const { return register_param_count_ >= 0; }
 
   int environment_length() const {
     return register_param_count_;
   }
 
   Representation GetParameterRepresentation(int index) const {
     return param_representations_[index];
   }
 
   Register GetParameterRegister(int index) const {
     return register_params_[index];
   }
 
   PlatformCallInterfaceDescriptor* platform_specific_descriptor() const {
     return platform_specific_descriptor_;
   }
 
+ private:
   int register_param_count_;
-  Register* register_params_;
-  Representation* param_representations_;
+  SmartArrayPointer<Register> register_params_;
+  SmartArrayPointer<Representation> param_representations_;
   PlatformCallInterfaceDescriptor* platform_specific_descriptor_;
 };
 
 
 class HydrogenCodeStub : public CodeStub {
  public:
   enum InitializationState {
     UNINITIALIZED,
     INITIALIZED
   };
@@ skipping 2109 matching lines @@
 
 
 class CallDescriptors {
  public:
   static void InitializeForIsolate(Isolate* isolate);
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_CODE_STUBS_H_