Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 350033005: Protect against unknown idl types (Closed)

Created:
6 years, 6 months ago by rwlbuis
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Protect against unknown idl types In case there is a Conditional for a type in the method declaration and the same type is being used in the parameter list, currently the idl can't be processed. Fix this by skipping include generation for unknown idl types. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/bindings/scripts/v8_types.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rwlbuis
PTAL.
6 years, 6 months ago (2014-06-26 21:51:46 UTC) #1
rwlbuis
Adding more reviewers.
6 years, 5 months ago (2014-06-30 15:29:50 UTC) #2
haraken
What IDL file is causing the issue specifically?
6 years, 5 months ago (2014-06-30 15:31:30 UTC) #3
rwlbuis
On 2014/06/30 15:31:30, haraken wrote: > What IDL file is causing the issue specifically? Take ...
6 years, 5 months ago (2014-06-30 17:05:38 UTC) #4
haraken
On 2014/06/30 17:05:38, rwlbuis wrote: > On 2014/06/30 15:31:30, haraken wrote: > > What IDL ...
6 years, 5 months ago (2014-06-30 23:16:29 UTC) #5
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 5 months ago (2014-07-01 14:20:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/350033005/1
6 years, 5 months ago (2014-07-01 14:20:59 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 15:24:24 UTC) #8
Message was sent while issue was closed.
Change committed as 177315

Powered by Google App Engine
This is Rietveld 408576698