Source/bindings/scripts/v8_types.py - Issue 350033005: Protect against unknown idl types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 350033005: Protect against unknown idl types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index 9630d71ecc864d91d765d02e7d8336c34e4e7976..a89f749f152d0352797806415a957b445bf6e3a8 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -343,6 +343,8 @@ def includes_for_type(idl_type):

if base_idl_type.endswith('Constructor'):

# FIXME: replace with a [ConstructorAttribute] extended attribute

base_idl_type = idl_type.constructor_type_name

+ if base_idl_type not in component_dir:

+ return set()

return set(['bindings/%s/v8/V8%s.h' % (component_dir[base_idl_type],

base_idl_type)])

« no previous file with comments | « no previous file | no next file » | no next file with comments »