Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 349923007: Implement media Cast button in Blink (Closed)

Created:
6 years, 6 months ago by aberent
Modified:
6 years, 3 months ago
CC:
chromium-reviews, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, whywhat
Project:
chromium
Visibility:
Public.

Description

Implement media Cast button in Blink This implements a Cast button in the default media controls, and a second, overlayed Cast button on videos that don't use the default controls. This replaces the previous implementation of the cast button in the Android UI. Pressing the Cast button asks the browser UI to bring up cast device selection menu. If a device is selected the video or audio will be played on that device, rather than locally. The Cast buttons are only displayed when there are cast devices available. Currently this is only implemented for Android; on other targets Chrome will always tell Blink that there are no devices available. Depends on Blink issue https://codereview.chromium.org/291163004/ BUG=390125 Committed: https://crrev.com/f8269e336bd6e3c2ac4c6bcf9cfcfda19d6742c6 Cr-Commit-Position: refs/heads/master@{#295253}

Patch Set 1 #

Patch Set 2 : Update for infomation and storage while I wait for feedback on crbug/388738 #

Patch Set 3 : Clean up #

Total comments: 2

Patch Set 4 : Rebase - move icon files to their new correct locations. #

Patch Set 5 : Rebase, now that the Blink patch has landed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -0 lines) Patch
M content/app/resources/content_resources.grd View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + content/app/resources/default_100_percent/mediaplayer_cast_off.png View 1 2 3 Binary file 0 comments Download
A + content/app/resources/default_100_percent/mediaplayer_cast_on.png View 1 2 3 Binary file 0 comments Download
M content/app/strings/content_strings.grd View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 4 3 chunks +12 lines, -0 lines 0 comments Download
M content/common/media/media_player_messages_android.h View 1 2 3 4 2 chunks +13 lines, -0 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.h View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.cc View 1 2 3 4 3 chunks +18 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 4 4 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (5 generated)
aberent
Work in progress, not ready for review.
6 years, 6 months ago (2014-06-23 13:51:51 UTC) #1
aberent
acolwell@chromium.org: Please review all (functional review, and owner review for the parts you own) tsepez@chromium.org: ...
6 years, 4 months ago (2014-08-04 16:59:23 UTC) #2
aberent
On 2014/06/23 13:51:51, aberent wrote: > Work in progress, not ready for review. Now ready ...
6 years, 4 months ago (2014-08-04 17:10:16 UTC) #3
Tom Sepez
> Now ready for review. Will have no effect until the Clank CL > (https://chrome-internal-review.googlesource.com/167055) ...
6 years, 4 months ago (2014-08-04 17:16:34 UTC) #4
michaeln
https://codereview.chromium.org/349923007/diff/60001/webkit/glue/webkit_strings.grd File webkit/glue/webkit_strings.grd (right): https://codereview.chromium.org/349923007/diff/60001/webkit/glue/webkit_strings.grd#newcode451 webkit/glue/webkit_strings.grd:451: <message name="IDS_AX_MEDIA_CAST_OFF_BUTTON" desc="accessibility role description for remote playback button"> ...
6 years, 4 months ago (2014-08-05 00:54:49 UTC) #5
acolwell GONE FROM CHROMIUM
lgtm
6 years, 4 months ago (2014-08-05 20:28:29 UTC) #6
aberent
https://codereview.chromium.org/349923007/diff/60001/webkit/glue/webkit_strings.grd File webkit/glue/webkit_strings.grd (right): https://codereview.chromium.org/349923007/diff/60001/webkit/glue/webkit_strings.grd#newcode451 webkit/glue/webkit_strings.grd:451: <message name="IDS_AX_MEDIA_CAST_OFF_BUTTON" desc="accessibility role description for remote playback button"> ...
6 years, 4 months ago (2014-08-05 20:49:08 UTC) #7
jam
lgtm
6 years, 4 months ago (2014-08-07 05:38:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/349923007/80001
6 years, 3 months ago (2014-09-17 09:07:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/57044) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/14553) win_chromium_x64_rel_swarming ...
6 years, 3 months ago (2014-09-17 09:10:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/349923007/100001
6 years, 3 months ago (2014-09-17 09:26:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/349923007/100001
6 years, 3 months ago (2014-09-17 10:51:38 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:100001) as 0577fffaa2f5e8501ab476771e2cd11669f8df1a
6 years, 3 months ago (2014-09-17 11:20:11 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 11:20:51 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f8269e336bd6e3c2ac4c6bcf9cfcfda19d6742c6
Cr-Commit-Position: refs/heads/master@{#295253}

Powered by Google App Engine
This is Rietveld 408576698