Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: dart/site/try/src/interaction_manager.dart

Issue 349683003: Improve running in iframes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r37602. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/site/try/src/iframe_error_handler.dart ('k') | dart/site/try/src/run.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/site/try/src/interaction_manager.dart
diff --git a/dart/site/try/src/interaction_manager.dart b/dart/site/try/src/interaction_manager.dart
index 9d4d1193cec4dbc3055d6df3efcec71149752b86..066c6f13800cf88a3008fe8c19aaf584a520ce54 100644
--- a/dart/site/try/src/interaction_manager.dart
+++ b/dart/site/try/src/interaction_manager.dart
@@ -76,6 +76,9 @@ import 'shadow_root.dart' show
removeShadowRootPolyfill,
setShadowRoot;
+import 'iframe_error_handler.dart' show
+ ErrorMessage;
+
const String TRY_DART_NEW_DEFECT =
'https://code.google.com/p/dart/issues/entry'
'?template=Try+Dart+Internal+Error';
@@ -160,6 +163,12 @@ abstract class InteractionManager {
// TODO(ahe): Remove this from InteractionManager, but not from InitialState.
void consolePrintLine(line);
+ /// Called just before running a freshly compiled program.
+ void aboutToRun();
+
+ /// Called when an error occurs when running user code in an iframe.
+ void onIframeError(ErrorMessage message);
+
void verboseCompilerMessage(String message);
}
@@ -268,6 +277,10 @@ class InteractionContext extends InteractionManager {
void consolePrintLine(line) => state.consolePrintLine(line);
+ void aboutToRun() => state.aboutToRun();
+
+ void onIframeError(ErrorMessage message) => state.onIframeError(message);
+
void verboseCompilerMessage(String message) {
return state.verboseCompilerMessage(message);
}
@@ -605,8 +618,6 @@ class InitialState extends InteractionState {
List message = event.data;
if (message.length > 0) {
switch (message[0]) {
- case 'error':
- return onErrorMessage(message[1]['url'], message[1]['message']);
case 'scrollHeight':
return onScrollHeightMessage(message[1]);
}
@@ -618,7 +629,7 @@ class InitialState extends InteractionState {
}
/// Called when an exception occurs in an iframe.
- void onErrorMessage(String url, String message) {
+ void onErrorMessage(ErrorMessage message) {
outputDiv.appendText('$message\n');
}
@@ -703,6 +714,17 @@ class InitialState extends InteractionState {
..addAll(mainEditorPane.querySelectorAll('a.diagnostic'));
}
+ void aboutToRun() {
+ context.shouldClearConsole = true;
+ }
+
+ void onIframeError(ErrorMessage message) {
+ // TODO(ahe): Consider replacing object URLs with something like <a
+ // href='...'>out.js</a>.
+ // TODO(ahe): Use source maps to translate stack traces.
+ consolePrintLine(message);
+ }
+
void verboseCompilerMessage(String message) {
if (settings.verboseCompiler) {
context.compilerConsole.appendText('$message\n');
« no previous file with comments | « dart/site/try/src/iframe_error_handler.dart ('k') | dart/site/try/src/run.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698