Improve running in iframes.

dart/site/try/src/interaction_manager.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library trydart.interaction_manager;
 
 import 'dart:html';
 
 import 'dart:convert' show
     JSON;
@@ skipping 58 matching lines @@
 import 'mock.dart' as mock;
 
 import 'settings.dart' as settings;
 
 import 'shadow_root.dart' show
     getShadowRoot,
     getText,
     removeShadowRootPolyfill,
     setShadowRoot;
 
+import 'iframe_error_handler.dart' show
+    ErrorMessage;
+
 const String TRY_DART_NEW_DEFECT =
     'https://code.google.com/p/dart/issues/entry'
     '?template=Try+Dart+Internal+Error';
 
 /// How frequently [InteractionManager.onHeartbeat] is called.
 const Duration HEARTBEAT_INTERVAL = const Duration(milliseconds: 50);
 
 /// Determines how frequently "project" files are saved.  The time is measured
 /// from the time of last modification.
 const Duration SAVE_INTERVAL = const Duration(seconds: 5);
@@ skipping 64 matching lines @@
 
   void onCompilationDone();
 
   /// Called when a compilation is starting, but just before sending the
   /// initiating message to the compiler isolate.
   void compilationStarting();
 
   // TODO(ahe): Remove this from InteractionManager, but not from InitialState.
   void consolePrintLine(line);
 
+  /// Called just before running a freshly compiled program.
+  void aboutToRun();
+
+  /// Called when an error occurs when running user code in an iframe.
+  void onIframeError(ErrorMessage message);
+
   void verboseCompilerMessage(String message);
 }
 
 /**
  * State machine for UI interactions.
  */
 class InteractionContext extends InteractionManager {
   InteractionState state;
 
   final Map<String, CompilationUnit> projectFiles = <String, CompilationUnit>{};
@@ skipping 88 matching lines @@
   void onWindowMessage(MessageEvent event) => state.onWindowMessage(event);
 
   void onCompilationFailed() => state.onCompilationFailed();
 
   void onCompilationDone() => state.onCompilationDone();
 
   void compilationStarting() => state.compilationStarting();
 
   void consolePrintLine(line) => state.consolePrintLine(line);
 
+  void aboutToRun() => state.aboutToRun();
+
+  void onIframeError(ErrorMessage message) => state.onIframeError(message);
+
   void verboseCompilerMessage(String message) {
     return state.verboseCompilerMessage(message);
   }
 }
 
 abstract class InteractionState implements InteractionManager {
   InteractionContext get context;
 
   // TODO(ahe): Remove this.
   Set<AnchorElement> get oldDiagnostics {
@@ skipping 317 matching lines @@
   }
 
   void onWindowMessage(MessageEvent event) {
     if (event.source is! WindowBase || event.source == window) {
       return onBadMessage(event);
     }
     if (event.data is List) {
       List message = event.data;
       if (message.length > 0) {
         switch (message[0]) {
-          case 'error':
-            return onErrorMessage(message[1]['url'], message[1]['message']);
           case 'scrollHeight':
             return onScrollHeightMessage(message[1]);
         }
       }
       return onBadMessage(event);
     } else {
       return consolePrintLine(event.data);
     }
   }
 
   /// Called when an exception occurs in an iframe.
-  void onErrorMessage(String url, String message) {
+  void onErrorMessage(ErrorMessage message) {
     outputDiv.appendText('$message\n');
   }
 
   /// Called when an iframe is modified.
   void onScrollHeightMessage(int scrollHeight) {
     window.console.log('scrollHeight = $scrollHeight');
     if (scrollHeight > 8) {
       outputFrame.style
           ..height = '${scrollHeight}px'
           ..visibility = ''
@@ skipping 64 matching lines @@
         ..start()
         ..reset();
     if (context.isFirstCompile) {
       outputDiv.append(context.compilerConsole);
     }
     context.oldDiagnostics
         ..clear()
         ..addAll(mainEditorPane.querySelectorAll('a.diagnostic'));
   }
 
+  void aboutToRun() {
+    context.shouldClearConsole = true;
+  }
+
+  void onIframeError(ErrorMessage message) {
+    // TODO(ahe): Consider replacing object URLs with something like <a
+    // href='...'>out.js</a>.
+    // TODO(ahe): Use source maps to translate stack traces.
+    consolePrintLine(message);
+  }
+
   void verboseCompilerMessage(String message) {
     if (settings.verboseCompiler) {
       context.compilerConsole.appendText('$message\n');
     } else {
       if (isCompilerStageMarker(message)) {
         Element progress = context.compilerConsole.firstChild;
         progress.appendText('.');
       }
     }
   }
@@ skipping 450 matching lines @@
 bool isCompilerStageMarker(String message) {
   return
       message.startsWith('Package root is ') ||
       message.startsWith('Compiling ') ||
       message == "Resolving..." ||
       message.startsWith('Resolved ') ||
       message == "Inferring types..." ||
       message == "Compiling..." ||
       message.startsWith('Compiled ');
 }