Issue 349653004: Merge 279934 "aw: Fix hardware teardown race"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 349653004: Merge 279934 "aw: Fix hardware teardown race" (Closed)

Created:
6 years, 6 months ago by boliu

Modified:
6 years, 6 months ago

Reviewers:
boliu

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/2062/src/

Project:
chromium

Visibility:
Public.

Merge 279934 "aw: Fix hardware teardown race" > aw: Fix hardware teardown race > > Reading IsHardwareInitialized in OnDetachedFromWindow on the UI thread > is unsafe as it can change after being read. Remove it and use whether > UI has hardware initialized instead. > > BUG=388890 > > Review URL: https://codereview.chromium.org/348613004 TBR=boliu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280049

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -30 lines)			Patch
M	android_webview/browser/browser_view_renderer.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	android_webview/browser/browser_view_renderer.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	android_webview/browser/shared_renderer_state.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	android_webview/browser/shared_renderer_state.cc	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	android_webview/native/aw_contents.cc	View	4 chunks	+1 line, -8 lines	0 comments	Download
M	android_webview/native/aw_dev_tools_server.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r280049.