aw: Fix hardware teardown race

aw: Fix hardware teardown race

Reading IsHardwareInitialized in OnDetachedFromWindow on the UI thread
is unsafe as it can change after being read. Remove it and use whether
UI has hardware initialized instead.

BUG=388890
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279934

[hush (inactive), 2014-06-25 21:51:57]

https://codereview.chromium.org/348613004/diff/1/android_webview/browser/brow...
File android_webview/browser/browser_view_renderer.h (right):

https://codereview.chromium.org/348613004/diff/1/android_webview/browser/brow...
android_webview/browser/browser_view_renderer.h:111: bool hardware_enabled()
const { return hardware_enabled_; }
hmm... can you put the implementation in cc file? That is what you did to
IsVisible(), IsAttachedToWindow

[hush (inactive), 2014-06-25 21:52:15]

lgtm

[boliu, 2014-06-25 21:54:33]

https://codereview.chromium.org/348613004/diff/1/android_webview/browser/brow...
File android_webview/browser/browser_view_renderer.h (right):

https://codereview.chromium.org/348613004/diff/1/android_webview/browser/brow...
android_webview/browser/browser_view_renderer.h:111: bool hardware_enabled()
const { return hardware_enabled_; }
On 2014/06/25 21:51:57, hush wrote:
> hmm... can you put the implementation in cc file? That is what you did to
> IsVisible(), IsAttachedToWindow

Simple accesstor for primitive types are allowed to be inlined, and should
follow this naming_style. IsVisible and GetScreenRect are not simple accesstors
though. I'll rename IsAttachedToWindow to this style and inline it.

[boliu, 2014-06-25 21:57:59]

And sgurun for committer stamp

[sgurun-gerrit only, 2014-06-25 23:50:19]

On 2014/06/25 21:57:59, boliu wrote:
> And sgurun for committer stamp

lgtm

[boliu, 2014-06-25 23:50:46]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-06-25 23:53:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/boliu@chromium.org/348613004/20001

[commit-bot: I haz the power, 2014-06-26 06:39:32]

Change committed as 279934