Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 349523003: DevTools: Unescape urls when showing them in navigator/editor. (Closed)

Created:
6 years, 6 months ago by vsevik
Modified:
6 years, 6 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Unescape urls when showing them in navigator/editor. BUG=161251 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176754

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/devtools/front_end/sdk/NetworkWorkspaceBinding.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vsevik
PTAL
6 years, 6 months ago (2014-06-20 08:16:22 UTC) #1
lushnikov
https://codereview.chromium.org/349523003/diff/1/Source/devtools/front_end/sdk/NetworkWorkspaceBinding.js File Source/devtools/front_end/sdk/NetworkWorkspaceBinding.js (right): https://codereview.chromium.org/349523003/diff/1/Source/devtools/front_end/sdk/NetworkWorkspaceBinding.js#newcode132 Source/devtools/front_end/sdk/NetworkWorkspaceBinding.js:132: var parentPath = unescape(splitURL.slice(1, splitURL.length - 1).join("/")); unescape is ...
6 years, 6 months ago (2014-06-23 10:03:15 UTC) #2
lushnikov
lgtm
6 years, 6 months ago (2014-06-23 11:28:32 UTC) #3
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 6 months ago (2014-06-23 12:22:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/349523003/20001
6 years, 6 months ago (2014-06-23 12:23:18 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 13:43:25 UTC) #6
Message was sent while issue was closed.
Change committed as 176754

Powered by Google App Engine
This is Rietveld 408576698