Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 349313007: Style resolver should not add margins to form control elements (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Style resolver should not add margins to form control elements. We added some margins to from control elements without width/height CSS properties. This behavior was not compatible with IE and Firefox, and was very confusing. We should remove such behavior. BUG=128306, 268692 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176850

Patch Set 1 : #

Total comments: 7

Patch Set 2 : remove wrong CSS properties #

Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -46 lines) Patch
M LayoutTests/TestExpectations View 5 chunks +401 lines, -7 lines 0 comments Download
M LayoutTests/fast/forms/button-with-float-expected.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/multicol/multicol-with-child-renderLayer-for-input.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/multicol-with-child-renderLayer-for-input-expected.html View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 2 chunks +4 lines, -36 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
tkent
Keishi, would you review this please? https://codereview.chromium.org/349313007/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (left): https://codereview.chromium.org/349313007/diff/20001/LayoutTests/TestExpectations#oldcode166 LayoutTests/TestExpectations:166: crbug.com/229207 [ Win ...
6 years, 6 months ago (2014-06-24 08:11:17 UTC) #1
keishi
https://codereview.chromium.org/349313007/diff/20001/LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html File LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html (right): https://codereview.chromium.org/349313007/diff/20001/LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html#newcode8 LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html:8: x-margin-top: 2px; What is x-margin-top?
6 years, 6 months ago (2014-06-24 08:18:41 UTC) #2
tkent
https://codereview.chromium.org/349313007/diff/20001/LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html File LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html (right): https://codereview.chromium.org/349313007/diff/20001/LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html#newcode8 LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html:8: x-margin-top: 2px; On 2014/06/24 08:18:40, keishi wrote: > What ...
6 years, 6 months ago (2014-06-24 08:19:28 UTC) #3
keishi
lgtm
6 years, 6 months ago (2014-06-24 08:36:05 UTC) #4
tkent
https://codereview.chromium.org/349313007/diff/20001/LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html File LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html (right): https://codereview.chromium.org/349313007/diff/20001/LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html#newcode8 LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html:8: x-margin-top: 2px; On 2014/06/24 08:19:28, tkent wrote: > On ...
6 years, 6 months ago (2014-06-24 08:47:17 UTC) #5
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-24 08:47:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/349313007/40001
6 years, 6 months ago (2014-06-24 08:48:19 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-24 09:50:10 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-24 10:24:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/21256)
6 years, 6 months ago (2014-06-24 10:24:51 UTC) #10
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-24 10:31:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/349313007/40001
6 years, 6 months ago (2014-06-24 10:32:25 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-24 11:26:27 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-24 12:30:33 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/21337)
6 years, 6 months ago (2014-06-24 12:30:34 UTC) #15
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-24 12:34:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/349313007/40001
6 years, 6 months ago (2014-06-24 12:34:53 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-24 13:26:39 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-24 14:01:45 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/21377)
6 years, 6 months ago (2014-06-24 14:01:46 UTC) #20
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-24 14:34:14 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/349313007/40001
6 years, 6 months ago (2014-06-24 14:34:54 UTC) #22
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-24 15:23:32 UTC) #23
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 16:14:14 UTC) #24
Message was sent while issue was closed. 
Change committed as 176850

Powered by Google App Engine
This is Rietveld 408576698