LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html - Issue 349313007: Style resolver should not add margins to form control elements

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/text/text-placeholder-in-flexbox-expected.html

Issue 349313007: Style resolver should not add margins to form control elements (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <body>	2 <body>

3 <style>	3 <style>

4 input {	4 input {

5 box-sizing: border-box;	5 box-sizing: border-box;

6 height: 196px;	6 x-height: 196px;

7 margin-top: 2px;	7 height: 200px;

	8 x-margin-top: 2px;
	keishi 2014/06/24 08:18:40 What is x-margin-top? What is x-margin-top? tkent 2014/06/24 08:19:28 Ah, this and x-height should be removed. Show quoted text On 2014/06/24 08:18:40, keishi wrote: > What is x-margin-top? Ah, this and x-height should be removed. tkent 2014/06/24 08:47:17 Removed. Show quoted text On 2014/06/24 08:19:28, tkent wrote: > On 2014/06/24 08:18:40, keishi wrote: > > What is x-margin-top? > > Ah, this and x-height should be removed. Removed.
8 }	9 }

9 </style>	10 </style>

10 <input type="text" placeholder="Username">	11 <input type="text" placeholder="Username">

11 </body>	12 </body>

OLD	NEW