mojo/services/test_service/test_service.mojom - Issue 349303006: mojo: add some end-to-end shell tests and a new test sample app

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/services/test_service/test_service.mojom

Issue 349303006: mojo: add some end-to-end shell tests and a new test sample app (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ServiceProvider rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « mojo/services/test_service/test_monitoring_application.cc ('k') | mojo/services/test_service/test_service_application.cc » ('j') | mojo/services/test_service/toy_monitoring_service_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module mojo.test {	5 module mojo.test {

6	6

7 interface ITestService {	7 interface TestService {

	8 const string kWelcomeMessagePrefix = "Party like it's ";
	viettrungluu 2014/06/30 17:08:24 I'm "surprised" we support const strings; I'm not I'm "surprised" we support const strings; I'm not sure if we should[] so perhaps we should avoid using them. [] Currently, the mojom bindings generator doesn't do any validation/escaping/etc. of strings, and we don't need string literals elsewhere. tim (not reviewing) 2014/06/30 22:20:54 Interesting. I saw a const string in sample_servic Show quoted text On 2014/06/30 17:08:24, viettrungluu wrote: > I'm "surprised" we support const strings; I'm not sure if we should[] so > perhaps we should avoid using them. > > [] Currently, the mojom bindings generator doesn't do any > validation/escaping/etc. of strings, and we don't need string literals > elsewhere. Interesting. I saw a const string in sample_service.mojom and also https://codereview.chromium.org/268363003, and assumed this was OK. I can remove it, I was only using it for convenience here, but I could imagine some services wanting to specify constant strings like this at some point.
8 Ping() => ();	9 Ping() => ();

	10 GetFriendlyWelcomeMessage(string time_app_url) => (string friendly_welcome);

	11 StartMonitoring() => ();
	viettrungluu 2014/06/30 17:08:24 Does this really need to have a response? Does this really need to have a response? tim (not reviewing) 2014/06/30 22:20:54 It wouldn't if I didn't care about verifying certa It wouldn't if I didn't care about verifying certain things are happening by a certain point. Otherwise something like service->StartMonitoring service->Ping ... loop->Run means the pings will always hit the service before the monitoring handshake has completed, which is fine except that you can't query the (separate) monitoring service and EXPECT_ that the pings were registered (yet). So to facilitate testing I opted to make it easy to track progress of the different steps. On 2014/06/30 17:08:24, viettrungluu wrote: Show quoted text > Does this really need to have a response?
	12 };

	13

	14 interface TestTimeService {

	15 GetPartyTime() => (int64 time_usec);

	16 StartMonitoring() => ();

9 };	17 };

10	18

11 } // module mojo.test	19 } // module mojo.test

OLD	NEW