Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 268363003: Mojo: Add support for constants to the IDL compiler. (Closed)

Created:
6 years, 7 months ago by Matt Perry
Modified:
6 years, 7 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Add support for constants to the IDL compiler. Only supports POD-types and strings currently. BUG=320091 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269659

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : JS export constants #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -62 lines) Patch
M mojo/public/interfaces/bindings/tests/sample_service.mojom View 4 chunks +6 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 2 chunks +13 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/module.js.tmpl View 1 2 2 chunks +10 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl View 2 chunks +14 lines, -11 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 3 chunks +11 lines, -5 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 1 4 chunks +18 lines, -17 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/data.py View 1 9 chunks +44 lines, -18 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/module.py View 1 chunk +19 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/lexer.py View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 4 chunks +8 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/translate.py View 4 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Matt Perry
6 years, 7 months ago (2014-05-07 18:19:30 UTC) #1
Matt Perry
ping
6 years, 7 months ago (2014-05-09 19:18:34 UTC) #2
DaveMoore
lgtm
6 years, 7 months ago (2014-05-09 20:59:09 UTC) #3
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 7 months ago (2014-05-09 21:46:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/268363003/40001
6 years, 7 months ago (2014-05-09 21:47:21 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 00:47:28 UTC) #6
Message was sent while issue was closed.
Change committed as 269659

Powered by Google App Engine
This is Rietveld 408576698