mock_system_utils.h - Issue 3493012: Security patches: RestartJob ignores pid, argv[0]; kill runs as child UID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mock_system_utils.h

Issue 3493012: Security patches: RestartJob ignores pid, argv[0]; kill runs as child UID (Closed) Base URL: http://git.chromium.org/git/login_manager.git

Patch Set: added comments, using -1 as suid in setresuid() calls Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mock_system_utils.h

diff --git a/mock_system_utils.h b/mock_system_utils.h

index e6ff21dc21849a0be73f3572bcc2fce687a98e1a..be4f5e149bc6381e3e69640bebbc4ecc036e381f 100644

--- a/mock_system_utils.h

+++ b/mock_system_utils.h

@@ -15,7 +15,7 @@ class MockSystemUtils : public SystemUtils {

public:

MockSystemUtils() {}

~MockSystemUtils() {}

- MOCK_METHOD2(kill, int(pid_t pid, int signal));

+ MOCK_METHOD3(kill, int(pid_t pid, uid_t uid, int signal));

MOCK_METHOD2(ChildIsGone, bool(pid_t child_spec, int timeout));

MOCK_METHOD2(EnsureAndReturnSafeFileSize,

bool(const FilePath& file, int32* file_size_32));

« no previous file with comments | « child_job_unittest.cc ('k') | session_manager_service.cc » ('j') | no next file with comments »