child_job_unittest.cc - Issue 3493012: Security patches: RestartJob ignores pid, argv[0]; kill runs as child UID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: child_job_unittest.cc

Issue 3493012: Security patches: RestartJob ignores pid, argv[0]; kill runs as child UID (Closed) Base URL: http://git.chromium.org/git/login_manager.git

Patch Set: added comments, using -1 as suid in setresuid() calls Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: child_job_unittest.cc

diff --git a/child_job_unittest.cc b/child_job_unittest.cc

index ab99c6675c1ea0f694ad4317a83da3bada5461bf..b65b3e61e1d5e9a494e682e4f8de1a97fad982c2 100644

--- a/child_job_unittest.cc

+++ b/child_job_unittest.cc

@@ -130,7 +130,8 @@ TEST(ChildJobTest, SetArguments) {

job.SetArguments(kNewArgsString);

ASSERT_EQ(arraysize(kNewArgsArray), job.arguments_.size());

- for (size_t i = 0; i < arraysize(kNewArgsArray); ++i) {

+ EXPECT_EQ(argv[0], job.arguments_[0]);

+ for (size_t i = 1; i < arraysize(kNewArgsArray); ++i) {

EXPECT_EQ(kNewArgsArray[i], job.arguments_[i]);

}

« no previous file with comments | « child_job.cc ('k') | mock_system_utils.h » ('j') | no next file with comments »