Adds AL logging for Blink core events.

Enables Activity Logger to log extension adding the following elements to the DOM:
- script
- link
- anchor
- iframe
- form
- input
- button

BUG=388287
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177105

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177245

[pmarch, 2014-06-23 15:17:12]

Hi Kentaro and Michael,

Could you take a look at this CL.

Thanks

[haraken, 2014-06-23 15:49:42]

We might want to announce our plan to blink-dev@ before inserting more
ActivityLogging code to core/. We can share the design document and mention that
we're improving the accuracy of the ActivityLogging and cleaning up the hacks in
the binding layer.

Since ActivityLogging is a privacy-sensitive mechanism, I think it would be
important to get a consensus of the Blink community before making changes that
affect the core part of the Blink.

https://codereview.chromium.org/349263002/diff/1/Source/core/html/HTMLAnchorE...
File Source/core/html/HTMLAnchorElement.cpp (right):

https://codereview.chromium.org/349263002/diff/1/Source/core/html/HTMLAnchorE...
Source/core/html/HTMLAnchorElement.cpp:363: if (insertionPoint->isInTreeScope())
{

Do you want to use isInTreeScope() or inDocument()?

https://codereview.chromium.org/349263002/diff/1/Source/core/html/HTMLAnchorE...
Source/core/html/HTMLAnchorElement.cpp:369:
activityLogger->logEvent("blinkAddElement", 2, argv.data());

2 => argv.length()

[pmarch, 2014-06-23 16:31:00]

https://codereview.chromium.org/349263002/diff/1/Source/core/html/HTMLAnchorE...
File Source/core/html/HTMLAnchorElement.cpp (right):

https://codereview.chromium.org/349263002/diff/1/Source/core/html/HTMLAnchorE...
Source/core/html/HTMLAnchorElement.cpp:363: if (insertionPoint->isInTreeScope())
{
On 2014/06/23 15:49:42, haraken wrote:
> 
> Do you want to use isInTreeScope() or inDocument()?

I am not familiar to how the shadow dom is used so I decided to log its
modifications as well. But, probably should have used inDocument().

I'll change it to inDocument()

https://codereview.chromium.org/349263002/diff/1/Source/core/html/HTMLAnchorE...
Source/core/html/HTMLAnchorElement.cpp:369:
activityLogger->logEvent("blinkAddElement", 2, argv.data());
On 2014/06/23 15:49:42, haraken wrote:
> 
> 2 => argv.length()

Done.

[pmarch, 2014-06-23 16:32:39]

On 2014/06/23 15:49:42, haraken wrote:
> We might want to announce our plan to blink-dev@ before inserting more
> ActivityLogging code to core/. We can share the design document and mention
that
> we're improving the accuracy of the ActivityLogging and cleaning up the hacks
in
> the binding layer.
> 
> Since ActivityLogging is a privacy-sensitive mechanism, I think it would be
> important to get a consensus of the Blink community before making changes that
> affect the core part of the Blink.

I will write a new design doc with planned changes to AL, and send it to
blink-dev@
Should the doc be world-visible or just google-visible?


>
https://codereview.chromium.org/349263002/diff/1/Source/core/html/HTMLAnchorE...
> File Source/core/html/HTMLAnchorElement.cpp (right):
> 
>
https://codereview.chromium.org/349263002/diff/1/Source/core/html/HTMLAnchorE...
> Source/core/html/HTMLAnchorElement.cpp:363: if
(insertionPoint->isInTreeScope())
> {
> 
> Do you want to use isInTreeScope() or inDocument()?
> 
>
https://codereview.chromium.org/349263002/diff/1/Source/core/html/HTMLAnchorE...
> Source/core/html/HTMLAnchorElement.cpp:369:
> activityLogger->logEvent("blinkAddElement", 2, argv.data());
> 
> 2 => argv.length()

[haraken, 2014-06-23 16:35:16]

> > We might want to announce our plan to blink-dev@ before inserting more
> > ActivityLogging code to core/. We can share the design document and mention
> that
> > we're improving the accuracy of the ActivityLogging and cleaning up the
hacks
> in
> > the binding layer.
> > 
> > Since ActivityLogging is a privacy-sensitive mechanism, I think it would be
> > important to get a consensus of the Blink community before making changes
that
> > affect the core part of the Blink.
> 
> I will write a new design doc with planned changes to AL, and send it to
> blink-dev@
> Should the doc be world-visible or just google-visible?

World-visible :)

[mvrable, 2014-06-23 17:14:46]

https://codereview.chromium.org/349263002/diff/20001/Source/core/dom/Node.idl
File Source/core/dom/Node.idl (left):

https://codereview.chromium.org/349263002/diff/20001/Source/core/dom/Node.idl...
Source/core/dom/Node.idl:52: [Custom, CustomElementCallbacks, PerWorldBindings,
LogActivity, RaisesException] Node insertBefore(Node newChild, Node refChild);
Here you are not removing PerWorldBindings, in other cases you are.  What's the
rationale for keeping or removing PerWorldBindings in each case?

[pmarch, 2014-06-24 09:53:08]

https://codereview.chromium.org/349263002/diff/20001/Source/core/dom/Node.idl
File Source/core/dom/Node.idl (left):

https://codereview.chromium.org/349263002/diff/20001/Source/core/dom/Node.idl...
Source/core/dom/Node.idl:52: [Custom, CustomElementCallbacks, PerWorldBindings,
LogActivity, RaisesException] Node insertBefore(Node newChild, Node refChild);
I remove PerWorldBindings in the cases where this does not impact performance in
negative way as measured by benchmarks. The measurements are here
https://docs.google.com/a/google.com/spreadsheets/d/198zOdCdybXb3FcbeYMcO8KTW...

On 2014/06/23 17:14:46, mvrable wrote:
> Here you are not removing PerWorldBindings, in other cases you are.  What's
the
> rationale for keeping or removing PerWorldBindings in each case?

[mvrable, 2014-06-24 16:15:20]

lgtm

[haraken, 2014-06-25 01:04:10]

LGTM, given the discussion in blink-dev@.
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Yzsx7H-gKrs

Would you file a tracking bug and add the bug number to the CL description?

[pmarch, 2014-06-25 16:15:10]

On 2014/06/25 01:04:10, haraken wrote:
> LGTM, given the discussion in blink-dev@.
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Yzsx7H-gKrs
> 
> Would you file a tracking bug and add the bug number to the CL description?

done

[pmarch, 2014-06-25 16:16:03]

Haraken

Take another look, please. I've added logging for button element.

Petr

[haraken, 2014-06-25 16:20:31]

On 2014/06/25 16:16:03, pmarch wrote:
> Haraken
> 
> Take another look, please. I've added logging for button element.
> 
> Petr

Still LGTM.

[pmarch, 2014-06-25 16:21:00]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-06-25 16:21:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/349263002/40001

[commit-bot: I haz the power, 2014-06-25 18:05:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/8506)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/12777)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/13568)

[commit-bot: I haz the power, 2014-06-25 18:08:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-25 18:08:25]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/8516)

[pmarch, 2014-06-26 08:47:30]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-06-26 08:48:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/349263002/40001

[commit-bot: I haz the power, 2014-06-26 10:29:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/8579)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/12890)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/13578)

[pmarch, 2014-06-26 10:31:36]

The CQ bit was unchecked by pmarch@chromium.org

[pmarch, 2014-06-26 10:33:45]

HI Pavel

Could you please look at Source/web/tests/ActivityLoggerTest.cpp

Thanks

[pfeldman, 2014-06-26 12:24:12]

rslgtm

[pmarch, 2014-06-26 12:38:32]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-06-26 12:39:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/349263002/40001

[commit-bot: I haz the power, 2014-06-26 14:21:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/12923)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/13766)

[commit-bot: I haz the power, 2014-06-26 14:50:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-26 14:50:24]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[pmarch, 2014-06-27 13:33:51]

On 2014/06/26 14:50:24, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_blink_rel on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

landed https://codereview.chromium.org/357873003 which should fix the failures
on try bots. I will test this CL locally and then attempt to commit.

[pmarch, 2014-06-27 13:35:09]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-06-27 13:35:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/349263002/40001

[commit-bot: I haz the power, 2014-06-27 14:35:23]

Change committed as 177105

[Timothy Loh, 2014-06-30 07:10:44]

A revert of this CL has been created in
https://codereview.chromium.org/355363002/ by timloh@chromium.org.

The reason for reverting is: This is blocking the blink roll
(https://codereview.chromium.org/346333005/) as it makes the test
AdInjectionBrowserTest.DetectAdInjections in browser_tests fail.

[pmarch, 2014-06-30 13:56:35]

On 2014/06/30 07:10:44, Timothy Loh wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/355363002/ by mailto:timloh@chromium.org.
> 
> The reason for reverting is: This is blocking the blink roll
> (https://codereview.chromium.org/346333005/) as it makes the test
> AdInjectionBrowserTest.DetectAdInjections in browser_tests fail.

Disabling AdInjectionBrowserTest.DetectAdInjections
https://codereview.chromium.org/361703002/

[pmarch, 2014-06-30 19:03:37]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-06-30 19:03:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/349263002/40001

[commit-bot: I haz the power, 2014-06-30 19:04:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-30 19:04:03]

Failed to apply patch for Source/core/dom/Document.idl:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Document.idl
  Hunk #2 FAILED at 42.
  1 out of 3 hunks FAILED -- saving rejects to file
Source/core/dom/Document.idl.rej

Patch:       Source/core/dom/Document.idl
Index: Source/core/dom/Document.idl
diff --git a/Source/core/dom/Document.idl b/Source/core/dom/Document.idl
index
512d8c038d47cad4708610e501ab7ac276c99f4f..aedb7d66c2e35bfdbc1330d7b685e81899acdd0c
100644
--- a/Source/core/dom/Document.idl
+++ b/Source/core/dom/Document.idl
@@ -31,7 +31,7 @@ typedef (CanvasRenderingContext2D or WebGLRenderingContext)
RenderingContext;
     readonly attribute DOMImplementation implementation;
     readonly attribute Element documentElement;
 
-    [CustomElementCallbacks, PerWorldBindings, LogActivity, RaisesException]
Element createElement(DOMString tagName);
+    [CustomElementCallbacks, PerWorldBindings, RaisesException] Element
createElement(DOMString tagName);
     DocumentFragment createDocumentFragment();
     Text createTextNode(DOMString data);
     Comment createComment(DOMString data);
@@ -42,8 +42,8 @@ typedef (CanvasRenderingContext2D or WebGLRenderingContext)
RenderingContext;
 
     // Introduced in DOM Level 2:
 
-    [CustomElementCallbacks, LogActivity, RaisesException] Node importNode(Node
node, optional boolean deep);
-    [CustomElementCallbacks, LogActivity, RaisesException] Element
createElementNS([TreatNullAs=NullString] DOMString namespaceURI, DOMString
qualifiedName);
+    [CustomElementCallbacks, RaisesException] Node importNode(Node node,
optional boolean deep);
+    [CustomElementCallbacks, RaisesException] Element
createElementNS([TreatNullAs=NullString] DOMString namespaceURI, DOMString
qualifiedName);
     [RaisesException, DeprecateAs=DocumentCreateAttributeNS] Attr
createAttributeNS([TreatNullAs=NullString,Default=Undefined] optional DOMString
namespaceURI,
                                                                                
  [TreatNullAs=NullString,Default=Undefined] optional DOMString qualifiedName);
// Removed from DOM4.
     HTMLCollection getElementsByTagNameNS([TreatNullAs=NullString] DOMString
namespaceURI, DOMString localName);
@@ -205,8 +205,8 @@ typedef (CanvasRenderingContext2D or WebGLRenderingContext)
RenderingContext;
     [RuntimeEnabled=Touch] TouchList createTouchList(Touch... touches);
 
     [CallWith=ScriptState, CustomElementCallbacks, RaisesException,
MeasureAs=DocumentRegisterElement] CustomElementConstructor
registerElement(DOMString name, optional Dictionary options);
-    [CustomElementCallbacks, PerWorldBindings, LogActivity, RaisesException]
Element createElement(DOMString localName, [TreatNullAs=NullString] DOMString
typeExtension);
-    [CustomElementCallbacks, LogActivity, RaisesException] Element
createElementNS([TreatNullAs=NullString] DOMString namespaceURI, DOMString
qualifiedName,
+    [CustomElementCallbacks, PerWorldBindings, RaisesException] Element
createElement(DOMString localName, [TreatNullAs=NullString] DOMString
typeExtension);
+    [CustomElementCallbacks, RaisesException] Element
createElementNS([TreatNullAs=NullString] DOMString namespaceURI, DOMString
qualifiedName,
                             [TreatNullAs=NullString] DOMString typeExtension);
 
     // Page visibility API.

[pmarch, 2014-06-30 19:11:35]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-06-30 19:11:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/349263002/60001

[commit-bot: I haz the power, 2014-06-30 20:16:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-06-30 23:19:48]

Change committed as 177245