Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 357873003: Check if the context is properly initialized before retrieving its script state. (Closed)

Created:
6 years, 5 months ago by pmarch
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Check if the context is properly initialized before retrieving its script state. BUG=389118 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177100

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M Source/bindings/v8/V8DOMActivityLogger.cpp View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pmarch
Kentaro Please review this CL. Thanks Petr
6 years, 5 months ago (2014-06-27 09:44:34 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-06-27 10:59:10 UTC) #2
pmarch
The CQ bit was checked by pmarch@chromium.org
6 years, 5 months ago (2014-06-27 11:40:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmarch@chromium.org/357873003/20001
6 years, 5 months ago (2014-06-27 11:41:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-27 12:46:39 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 13:15:37 UTC) #6
Message was sent while issue was closed.
Change committed as 177100

Powered by Google App Engine
This is Rietveld 408576698