Enable the Vibration API in stable.

Enable the Vibration API in stable.

The approved intent to implement and ship is here:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/vibration$20api/blink-dev/hH9bJGWKAbk/AFPov-g5VMMJ

BUG=222504
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160711

[Michael van Ouwerkerk, 2013-10-22 10:13:17]

peter as feature reviewer
jochen as owner of core

[Peter Beverloo, 2013-10-22 12:43:10]

Can you verify what the remaining work is for our implementation to be
completely in sync with the specification?

  (1) Following the October 14 change to the spec, vibrations should be "owned"
by their browsing context.  One frame can't cancel the vibration of another
frame.  I don't think we implement this behavior yet (http://crbug.com/305642).
  (2) Undefined behavior in case a developer calls navigator.vibrate(-1).
  (3) We don't actually test the feature a lot yet.  The main case I'd like to
see tested is navigator.vibrate(50000) which should actually vibrate for 10000ms
because of the truncating behavior.

Since the feature is relatively simple, the logic isn't that complicated and
usage will be fairly low. I'm not too concerned about it though.  At the very
least, please file bugs for (2) and (3).

Will we expose the API on the desktop platforms, even though we're pretty much
guaranteed to not have a vibrator present there?

[Michael van Ouwerkerk, 2013-10-25 15:58:41]

On 2013/10/22 12:43:10, Peter Beverloo wrote:
> Can you verify what the remaining work is for our implementation to be
> completely in sync with the specification?
> 
>   (1) Following the October 14 change to the spec, vibrations should be
"owned"
> by their browsing context.  One frame can't cancel the vibration of another
> frame.  I don't think we implement this behavior yet
(http://crbug.com/305642).
This probably won't be fixed before release but it's an edge case. 

>   (2) Undefined behavior in case a developer calls navigator.vibrate(-1).
Tracked in http://crbug.com/310138
We cannot yet fix the sequence case because Web IDL / Blink's implementation of
Web IDL does not support Clamp with a sequence. The single unsigned long
argument version of the API has been fixed.

The bug for adding Clamp support to sequences is at http://crbug.com/309700


>   (3) We don't actually test the feature a lot yet.
Patch https://codereview.chromium.org/40443002/ is in the CQ now.

> Will we expose the API on the desktop platforms, even though we're pretty much
> guaranteed to not have a vibrator present there?
Yes.

[Peter Beverloo, 2013-10-25 17:24:00]

lgtm (but not an API owner), since usage of this API will be relatively minor
and the remaining bugs are not deal-breakers.

Please prioritize the remaining bugs and try to get them fixed before branch
point.

[Michael van Ouwerkerk, 2013-10-25 17:56:48]

Adam, could you please take a look as owner? I'm assuming jochen is done working
for this week.

[abarth-chromium, 2013-10-26 00:44:34]

lgtm

\o/

[commit-bot: I haz the power, 2013-10-26 00:44:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/34923002/1

[commit-bot: I haz the power, 2013-10-26 00:44:47]

Failed to apply patch for Source/core/page/RuntimeEnabledFeatures.in:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: Source/core/page/RuntimeEnabledFeatures.in
  |diff --git a/Source/core/page/RuntimeEnabledFeatures.in
b/Source/core/page/RuntimeEnabledFeatures.in
  |index
183c1c1ed066912af322198ccfe0ec9decec168b..fc8686958b8ed004736757e616940a903d1d4c77
100644
  |--- a/Source/core/page/RuntimeEnabledFeatures.in
  |+++ b/Source/core/page/RuntimeEnabledFeatures.in
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       Source/core/page/RuntimeEnabledFeatures.in
Index: Source/core/page/RuntimeEnabledFeatures.in
diff --git a/Source/core/page/RuntimeEnabledFeatures.in
b/Source/core/page/RuntimeEnabledFeatures.in
index
183c1c1ed066912af322198ccfe0ec9decec168b..fc8686958b8ed004736757e616940a903d1d4c77
100644
--- a/Source/core/page/RuntimeEnabledFeatures.in
+++ b/Source/core/page/RuntimeEnabledFeatures.in
@@ -106,7 +106,7 @@ SVGPaintOrder status=experimental
 Touch status=stable
 
 UserSelectAll status=experimental
-Vibration status=experimental
+Vibration status=stable
 VideoTrack status=stable
 WebAnimations
 WebAnimationsCSS depends_on=WebAnimations

[commit-bot: I haz the power, 2013-10-26 11:55:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/34923002/13...

[commit-bot: I haz the power, 2013-10-26 12:42:39]

Retried try job too often on win_blink_rel for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-10-26 13:29:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/34923002/13...

[commit-bot: I haz the power, 2013-10-26 14:38:30]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-10-26 15:42:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/34923002/13...

[commit-bot: I haz the power, 2013-10-26 16:46:11]

Retried try job too often on win_blink_rel for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-10-28 09:31:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/34923002/13...

[commit-bot: I haz the power, 2013-10-28 10:15:20]

Change committed as 160711