Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 348893002: Fixed flakiness in GetMostRecentlyAddedUserNodeForURLSkipsManagedNodes. (Closed)

Created:
6 years, 6 months ago by Joao da Silva
Modified:
6 years, 6 months ago
Reviewers:
MAD, sky
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Fixed flakiness in GetMostRecentlyAddedUserNodeForURLSkipsManagedNodes. base::Time::Now() doesn't guarantee that successive calls don't get the same value, and this seems to be happening on some Windows systems when two BookmarkNodes are created one after the other in a unit test. R=mad@chromium.org TBR=sky@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/bookmarks/browser/bookmark_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Joao da Silva
Thanks for the heads up about this test. The test error log and the documentation ...
6 years, 6 months ago (2014-06-20 19:46:12 UTC) #1
MAD
My pleasure... Thanks for the fix! :-) LGTM BYE MAD
6 years, 6 months ago (2014-06-20 19:53:06 UTC) #2
Joao da Silva
+sky to TBR
6 years, 6 months ago (2014-06-20 19:56:04 UTC) #3
Joao da Silva
6 years, 6 months ago (2014-06-20 19:57:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r278805 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698