components/bookmarks/browser/bookmark_model_unittest.cc - Issue 348893002: Fixed flakiness in GetMostRecentlyAddedUserNodeForURLSkipsManagedNodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_model_unittest.cc

Issue 348893002: Fixed flakiness in GetMostRecentlyAddedUserNodeForURLSkipsManagedNodes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/bookmarks/browser/bookmark_model_unittest.cc

diff --git a/components/bookmarks/browser/bookmark_model_unittest.cc b/components/bookmarks/browser/bookmark_model_unittest.cc

index b198ae4efad6878c71c4c9517cda05ade33f6bd8..fbdb34ad40e1cc41961435d40e714a654c39edb6 100644

--- a/components/bookmarks/browser/bookmark_model_unittest.cc

+++ b/components/bookmarks/browser/bookmark_model_unittest.cc

@@ -1173,7 +1173,7 @@ TEST_F(BookmarkModelTest, GetMostRecentlyAddedUserNodeForURLSkipsManagedNodes) {

// Having a more recent managed node doesn't count either.

const BookmarkNode* managed = model_->AddURL(managed_parent, 0, title, url);

- EXPECT_GT(managed->date_added(), user->date_added());

+ EXPECT_GE(managed->date_added(), user->date_added());

EXPECT_EQ(user, model_->GetMostRecentlyAddedUserNodeForURL(url));

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »