Issue 348663003: Work toward a chrome/common GN target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348663003: Work toward a chrome/common GN target. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, cbentzel+watch_chromium.org, Ilya Sherman, asvitkine+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Work toward a chrome/common GN target. This adds more of the chrome/common target. The sources don't all compile yet so this is commented out. Add many resources targets required my chrome/common. R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278586

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+222 lines, -61 lines)			Patch
M	BUILD.gn	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	build/gypi_to_gn.py	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/BUILD.gn	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/app/BUILD.gn	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A +	chrome/app/resources/BUILD.gn	View		1 chunk	+4 lines, -4 lines	0 comments	Download
A +	chrome/app/theme/BUILD.gn	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/chrome_common.gypi	View		4 chunks	+36 lines, -47 lines	0 comments	Download
M	chrome/chrome_resources.gyp	View		6 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/common/BUILD.gn	View		2 chunks	+128 lines, -4 lines	0 comments	Download
M	chrome/common/metrics/proto/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/net/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common_constants.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

brettw

6 years, 6 months ago (2014-06-20 04:26:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r278586 (presubmit successful).