Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: BUILD.gn

Issue 348663003: Work toward a chrome/common GN target. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: no android Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/gypi_to_gn.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index f24a8c67abdd85a25bce15fe014a95273ed9f953..a39b3c95ba872a48e3364cb0fa7ce407734145d5 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -21,7 +21,7 @@ group("root") {
"//apps/common/api:apps_api",
"//cc",
- "//chrome:resources",
+ "//chrome/common",
"//components/favicon_base",
"//components/language_usage_metrics",
"//components/metrics",
@@ -138,6 +138,7 @@ group("root") {
if (is_android) {
deps -= [
"//cc",
+ "//chrome/common", # Blocked on content.
"//content",
"//components/user_prefs", # Blocked on content.
"//components/visitedlink/browser", # Blocked on content.
« no previous file with comments | « no previous file | build/gypi_to_gn.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698