Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 34863002: [CSS Regions] Layout Test for selecting text ignoring region content (Closed)

Created:
7 years, 2 months ago by Manuel Rego
Modified:
7 years, 2 months ago
CC:
blink-reviews, chromiumbugtracker_adobe.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Layout Test for selecting text ignoring region content Patch already landed in WebKit. See http://trac.webkit.org/changeset/156962 Add new reftests for selecting text in texts wrapping a region, where the region content is ignored. It compares the behavior (highlighted text and selected content) in regions and absolute positions. Absolute positioned elements do not fill the gaps on the right during the selection, unlike regular elements. This is the reason why some regular elements are floated in order to avoid such problems in the reftests. Provided layout tests for different writing models. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160550

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
Manuel Rego
7 years, 2 months ago (2013-10-22 09:51:06 UTC) #1
ojan
lgtm
7 years, 2 months ago (2013-10-24 22:11:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/34863002/1
7 years, 2 months ago (2013-10-24 22:12:04 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-24 23:13:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/34863002/1
7 years, 2 months ago (2013-10-25 05:56:58 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-25 08:00:10 UTC) #6
Message was sent while issue was closed.
Change committed as 160550

Powered by Google App Engine
This is Rietveld 408576698