Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1413)

Unified Diff: android_webview/native/aw_contents.cc

Issue 348613004: aw: Fix hardware teardown race (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/shared_renderer_state.cc ('k') | android_webview/native/aw_dev_tools_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_contents.cc
diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc
index dd673adb742927f9c6ba1129e558cc963d805a6b..de623394f34c290f99592e12b108b5b4a6c71471 100644
--- a/android_webview/native/aw_contents.cc
+++ b/android_webview/native/aw_contents.cc
@@ -358,7 +358,6 @@ void AwContents::DrawGL(AwDrawGLInfo* draw_info) {
if (!shared_renderer_state_.IsHardwareAllowed()) {
hardware_renderer_.reset();
- shared_renderer_state_.SetHardwareInitialized(false);
return;
}
@@ -366,9 +365,7 @@ void AwContents::DrawGL(AwDrawGLInfo* draw_info) {
return;
if (!hardware_renderer_) {
- DCHECK(!shared_renderer_state_.IsHardwareInitialized());
hardware_renderer_.reset(new HardwareRenderer(&shared_renderer_state_));
- shared_renderer_state_.SetHardwareInitialized(true);
}
if (hardware_renderer_->DrawGL(state_restore.stencil_enabled(),
@@ -866,7 +863,7 @@ void AwContents::OnDetachedFromWindow(JNIEnv* env, jobject obj) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
shared_renderer_state_.SetHardwareAllowed(false);
- bool hardware_initialized = shared_renderer_state_.IsHardwareInitialized();
+ bool hardware_initialized = browser_view_renderer_.hardware_enabled();
if (hardware_initialized) {
bool draw_functor_succeeded = RequestDrawGL(NULL, true);
if (!draw_functor_succeeded) {
@@ -1138,10 +1135,6 @@ void AwContents::TrimMemory(JNIEnv* env,
jint level,
jboolean visible) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-
- if (!shared_renderer_state_.IsHardwareInitialized())
- return;
-
browser_view_renderer_.TrimMemory(level, visible);
}
« no previous file with comments | « android_webview/browser/shared_renderer_state.cc ('k') | android_webview/native/aw_dev_tools_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698