Don't force full invalidation on box-sizing change

Don't force full invalidation on box-sizing change

The renderer can already correctly handle invalidations of geometry changes
caused by box-sizing change.

BUG=375876
TEST=fast/repaint/box-sizing.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176716

[esprehn, 2014-06-20 08:15:15]

This lgtm, but can you explain in the change description why it's okay not to do
this, and why the test issues so many invalidations now?

https://codereview.chromium.org/348493003/diff/1/LayoutTests/fast/repaint/box...
File LayoutTests/fast/repaint/box-sizing-expected.txt (right):

https://codereview.chromium.org/348493003/diff/1/LayoutTests/fast/repaint/box...
LayoutTests/fast/repaint/box-sizing-expected.txt:12: (rect 0.00 80.00 440.00
20.00)
Why do we issue 4 invalidations instead of just 1 now?

[Xianzhu, 2014-06-20 16:06:17]

Done modifying description.

https://codereview.chromium.org/348493003/diff/1/LayoutTests/fast/repaint/box...
File LayoutTests/fast/repaint/box-sizing-expected.txt (right):

https://codereview.chromium.org/348493003/diff/1/LayoutTests/fast/repaint/box...
LayoutTests/fast/repaint/box-sizing-expected.txt:12: (rect 0.00 80.00 440.00
20.00)
On 2014/06/20 08:15:15, esprehn wrote:
> Why do we issue 4 invalidations instead of just 1 now?

This is a new test. There is no original file actually, but codereview/git
selected some similar file as the original file :)

[Xianzhu, 2014-06-20 17:06:14]

Can't CQ because it needs https://codereview.chromium.org/312193004/ to work
properly.

[Xianzhu, 2014-06-23 00:57:51]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-06-23 00:58:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/348493003/20001

[Xianzhu, 2014-06-23 01:07:18]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-06-23 01:07:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/348493003/40001

[commit-bot: I haz the power, 2014-06-23 02:08:00]

Change committed as 176716

[ojan, 2014-06-23 05:03:06]

Can you also test the case of the box-sizing changing but the width/height of
the element staying the same? For example, change the box-sizing, but adjust the
border/padding so it stays the same size.

[Xianzhu, 2014-06-23 18:49:44]

On 2014/06/23 05:03:06, OOO-only-code-yellow-reviews wrote:
> Can you also test the case of the box-sizing changing but the width/height of
> the element staying the same? For example, change the box-sizing, but adjust
the
> border/padding so it stays the same size.

Thanks for the suggestion. Added cases in
https://codereview.chromium.org/350043003/.