Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: Source/core/rendering/style/RenderStyle.cpp

Issue 348493003: Don't force full invalidation on box-sizing change (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update test expectation Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/repaint/box-sizing-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/style/RenderStyle.cpp
diff --git a/Source/core/rendering/style/RenderStyle.cpp b/Source/core/rendering/style/RenderStyle.cpp
index 02cd9cd337034b2f9afcf613b8895e5faeae82ac..43fedd29bc3bc2361fad3db8cb6022937664b6d5 100644
--- a/Source/core/rendering/style/RenderStyle.cpp
+++ b/Source/core/rendering/style/RenderStyle.cpp
@@ -422,11 +422,6 @@ bool RenderStyle::diffNeedsFullLayoutAndRepaint(const RenderStyle& other) const
// - or the renderer knows how to exactly repaint caused by the layout change
// instead of forced full repaint.
- if (m_box.get() != other.m_box.get()) {
- if (m_box->boxSizing() != other.m_box->boxSizing())
- return true;
- }
-
if (surround.get() != other.surround.get()) {
if (surround->margin != other.surround->margin)
return true;
@@ -613,6 +608,9 @@ bool RenderStyle::diffNeedsFullLayout(const RenderStyle& other) const
if (m_box->verticalAlign() != other.m_box->verticalAlign())
return true;
+
+ if (m_box->boxSizing() != other.m_box->boxSizing())
+ return true;
}
if (noninherited_flags._vertical_align != other.noninherited_flags._vertical_align)
« no previous file with comments | « LayoutTests/fast/repaint/box-sizing-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698