Issue 348303002: Move invodeCallback from V8Callback to V8Binding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348303002: Move invodeCallback from V8Callback to V8Binding (Closed)

Created:
6 years, 6 months ago by kihong

Modified:
6 years, 6 months ago

Reviewers:
haraken, Nils Barth (inactive)

CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, arv+blink, blink-reviews-css, ed+blinkwatch_opera.com, abarth-chromium, dglazkov+blink, blink-reviews-bindings_chromium.org, darktears, apavlov+blink_chromium.org, rwlbuis, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Move invodeCallback from V8Callback to V8Binding Because of removing "V8GeolocationCustom.cpp", "invokeCallback" functions are only left in "V8Callback". They could be moved to "V8Binding" becuase they are related to binding. In addition, "V8Callback.h/cpp" could be removed. BUG=387640 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176743

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -101 lines)			Patch
M	Source/bindings/scripts/v8_callback_interface.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestCallbackInterface.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/v8/V8Binding.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/bindings/v8/V8Binding.cpp	View	1 chunk	+13 lines, -0 lines	0 comments	Download
D	Source/bindings/v8/V8Callback.h	View	1 chunk	+0 lines, -45 lines	0 comments	Download
D	Source/bindings/v8/V8Callback.cpp	View	1 chunk	+0 lines, -51 lines	0 comments	Download
M	Source/bindings/v8/v8.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/css/MediaQueryListListener.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/348303002/1

6 years, 6 months ago (2014-06-23 11:18:39 UTC) #4

Message was sent while issue was closed.

Change committed as 176743

Expand Messages | Collapse Messages