Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: Source/bindings/scripts/v8_callback_interface.py

Issue 348303002: Move invodeCallback from V8Callback to V8Binding (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestCallbackInterface.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 27 matching lines...) Expand all
38 import v8_types 38 import v8_types
39 import v8_utilities 39 import v8_utilities
40 40
41 CALLBACK_INTERFACE_H_INCLUDES = frozenset([ 41 CALLBACK_INTERFACE_H_INCLUDES = frozenset([
42 'bindings/v8/ActiveDOMCallback.h', 42 'bindings/v8/ActiveDOMCallback.h',
43 'bindings/v8/DOMWrapperWorld.h', 43 'bindings/v8/DOMWrapperWorld.h',
44 'bindings/v8/ScopedPersistent.h', 44 'bindings/v8/ScopedPersistent.h',
45 ]) 45 ])
46 CALLBACK_INTERFACE_CPP_INCLUDES = frozenset([ 46 CALLBACK_INTERFACE_CPP_INCLUDES = frozenset([
47 'bindings/v8/V8Binding.h', 47 'bindings/v8/V8Binding.h',
48 'bindings/v8/V8Callback.h',
49 'core/dom/ExecutionContext.h', 48 'core/dom/ExecutionContext.h',
50 'wtf/Assertions.h', 49 'wtf/Assertions.h',
51 'wtf/GetPtr.h', 50 'wtf/GetPtr.h',
52 'wtf/RefPtr.h', 51 'wtf/RefPtr.h',
53 ]) 52 ])
54 53
55 54
56 def cpp_type(idl_type): 55 def cpp_type(idl_type):
57 # FIXME: remove this function by making callback types consistent 56 # FIXME: remove this function by making callback types consistent
58 # (always use usual v8_types.cpp_type) 57 # (always use usual v8_types.cpp_type)
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 } 124 }
126 125
127 argument_declarations = ['ScriptValue thisValue'] if call_with_this_handle e lse [] 126 argument_declarations = ['ScriptValue thisValue'] if call_with_this_handle e lse []
128 argument_declarations.extend( 127 argument_declarations.extend(
129 '%s %s' % (argument.idl_type.callback_cpp_type, argument.name) 128 '%s %s' % (argument.idl_type.callback_cpp_type, argument.name)
130 for argument in arguments) 129 for argument in arguments)
131 return { 130 return {
132 'argument_declarations': argument_declarations, 131 'argument_declarations': argument_declarations,
133 'arguments': [generate_argument(argument) for argument in arguments], 132 'arguments': [generate_argument(argument) for argument in arguments],
134 } 133 }
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestCallbackInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698